Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(708)

Side by Side Diff: content/public/browser/web_contents_observer.h

Issue 1374053002: Remove AboutToNavigateRenderFrame, issue custom notification for DevTools. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_OBSERVER_H_ 5 #ifndef CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_OBSERVER_H_
6 #define CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_OBSERVER_H_ 6 #define CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_OBSERVER_H_
7 7
8 #include "base/process/kill.h" 8 #include "base/process/kill.h"
9 #include "base/process/process_handle.h" 9 #include "base/process/process_handle.h"
10 #include "content/common/content_export.h" 10 #include "content/common/content_export.h"
(...skipping 188 matching lines...) Expand 10 before | Expand all | Expand 10 after
199 // This method is like DidFinishLoad, but when the load failed or was 199 // This method is like DidFinishLoad, but when the load failed or was
200 // cancelled, e.g. window.stop() is invoked. 200 // cancelled, e.g. window.stop() is invoked.
201 virtual void DidFailLoad(RenderFrameHost* render_frame_host, 201 virtual void DidFailLoad(RenderFrameHost* render_frame_host,
202 const GURL& validated_url, 202 const GURL& validated_url,
203 int error_code, 203 int error_code,
204 const base::string16& error_description, 204 const base::string16& error_description,
205 bool was_ignored_by_handler) {} 205 bool was_ignored_by_handler) {}
206 206
207 // --------------------------------------------------------------------------- 207 // ---------------------------------------------------------------------------
208 208
209 // This method is invoked after the WebContents decides which RenderFrameHost
210 // to use for the next browser-initiated navigation, but before the navigation
211 // starts. It is not called for most renderer-initiated navigations, and it
212 // does not guarantee that the navigation will commit (e.g., 204s, downloads).
213 //
214 // DEPRECATED. This method is difficult to use correctly and should be
215 // removed. TODO(creis): Remove in http://crbug.com/424641.
216 virtual void AboutToNavigateRenderFrame(RenderFrameHost* old_host,
217 RenderFrameHost* new_host) {}
218
219 // This method is invoked after the browser process starts a navigation to a 209 // This method is invoked after the browser process starts a navigation to a
220 // pending NavigationEntry. It is not called for renderer-initiated 210 // pending NavigationEntry. It is not called for renderer-initiated
221 // navigations unless they are sent to the browser process via OpenURL. It may 211 // navigations unless they are sent to the browser process via OpenURL. It may
222 // be called multiple times for a given navigation, such as a typed URL 212 // be called multiple times for a given navigation, such as a typed URL
223 // followed by a cross-process client or server redirect. 213 // followed by a cross-process client or server redirect.
224 virtual void DidStartNavigationToPendingEntry( 214 virtual void DidStartNavigationToPendingEntry(
225 const GURL& url, 215 const GURL& url,
226 NavigationController::ReloadType reload_type) {} 216 NavigationController::ReloadType reload_type) {}
227 217
228 // |render_frame_host| is the RenderFrameHost for which the provisional load 218 // |render_frame_host| is the RenderFrameHost for which the provisional load
(...skipping 236 matching lines...) Expand 10 before | Expand all | Expand 10 after
465 void ResetWebContents(); 455 void ResetWebContents();
466 456
467 WebContentsImpl* web_contents_; 457 WebContentsImpl* web_contents_;
468 458
469 DISALLOW_COPY_AND_ASSIGN(WebContentsObserver); 459 DISALLOW_COPY_AND_ASSIGN(WebContentsObserver);
470 }; 460 };
471 461
472 } // namespace content 462 } // namespace content
473 463
474 #endif // CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_OBSERVER_H_ 464 #endif // CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_OBSERVER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698