Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1041)

Unified Diff: content/browser/frame_host/render_frame_host_impl.cc

Issue 1374053002: Remove AboutToNavigateRenderFrame, issue custom notification for DevTools. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/frame_host/navigator_impl.cc ('k') | content/browser/web_contents/web_contents_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/frame_host/render_frame_host_impl.cc
diff --git a/content/browser/frame_host/render_frame_host_impl.cc b/content/browser/frame_host/render_frame_host_impl.cc
index 16e89ef367050c8467f2e46a5e5606bd5fa29da3..66a4f63dcbbdcee9069c08d3b3bc2a781a13f7ce 100644
--- a/content/browser/frame_host/render_frame_host_impl.cc
+++ b/content/browser/frame_host/render_frame_host_impl.cc
@@ -17,6 +17,7 @@
#include "content/browser/accessibility/browser_accessibility_state_impl.h"
#include "content/browser/bad_message.h"
#include "content/browser/child_process_security_policy_impl.h"
+#include "content/browser/devtools/render_frame_devtools_agent_host.h"
#include "content/browser/frame_host/cross_process_frame_connector.h"
#include "content/browser/frame_host/cross_site_transferring_request.h"
#include "content/browser/frame_host/frame_mojo_shell.h"
@@ -1704,6 +1705,8 @@ void RenderFrameHostImpl::Navigate(
// completing a RFH swap or unload handler.
SetState(RenderFrameHostImpl::STATE_DEFAULT);
+ RenderFrameDevToolsAgentHost::OnBeforeNavigation(
+ frame_tree_node_->current_frame_host(), this);
Send(new FrameMsg_Navigate(routing_id_, common_params, start_params,
yurys 2015/09/28 23:37:30 Let's extract this into a method to avoid FrameMsg
dgozman 2015/10/01 20:15:26 Done.
request_params));
}
@@ -2108,6 +2111,8 @@ void RenderFrameHostImpl::SetNavigationsSuspended(
DCHECK(!proceed_time.is_null());
suspended_nav_params_->request_params.browser_navigation_start =
proceed_time;
+ RenderFrameDevToolsAgentHost::OnBeforeNavigation(
+ frame_tree_node_->current_frame_host(), this);
Send(new FrameMsg_Navigate(routing_id_,
suspended_nav_params_->common_params,
suspended_nav_params_->start_params,
« no previous file with comments | « content/browser/frame_host/navigator_impl.cc ('k') | content/browser/web_contents/web_contents_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698