Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 1315303009: Cleanup DeprecatedPaintLayer::physicalBoundingBox() and derivatives (Closed)

Created:
5 years, 3 months ago by trchen
Modified:
5 years, 3 months ago
Reviewers:
pdr.
CC:
blink-reviews, blink-reviews-paint_chromium.org, blink-reviews-rendering, dshwang, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, slimming-paint-reviews_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Cleanup DeprecatedPaintLayer::physicalBoundingBox() and derivatives DeprecatedPaintLayer::physicalBoundingBox() returns the layer bounding box in physical direction, translated to an ancestor layer's space. The caller can either specify the ancestor layer or a pre-computed translation. Only one of the parameter will be used. This CL overloads the function to remove the extraneous argument at callers. No behavioral change, no test added. BUG=508383 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201772

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -22 lines) Patch
M Source/core/layout/LayoutTreeAsText.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M Source/core/paint/DeprecatedPaintLayer.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/paint/DeprecatedPaintLayer.cpp View 6 chunks +15 lines, -13 lines 0 comments Download
M Source/core/paint/DeprecatedPaintLayerPainter.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/paint/FilterPainter.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
trchen
5 years, 3 months ago (2015-09-04 03:25:58 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1315303009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1315303009/1
5 years, 3 months ago (2015-09-04 03:26:17 UTC) #4
pdr.
LGTM I added "BUG=508383" to the change description so we can keep these together.
5 years, 3 months ago (2015-09-04 03:46:33 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-04 04:33:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1315303009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1315303009/1
5 years, 3 months ago (2015-09-04 04:41:39 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-09-04 04:46:00 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201772

Powered by Google App Engine
This is Rietveld 408576698