Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1076)

Side by Side Diff: Source/core/paint/DeprecatedPaintLayer.h

Issue 1315303009: Cleanup DeprecatedPaintLayer::physicalBoundingBox() and derivatives (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/layout/LayoutTreeAsText.cpp ('k') | Source/core/paint/DeprecatedPaintLayer.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2003, 2009, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2003, 2009, 2012 Apple Inc. All rights reserved.
3 * Copyright (C) 2013 Intel Corporation. All rights reserved. 3 * Copyright (C) 2013 Intel Corporation. All rights reserved.
4 * 4 *
5 * Portions are Copyright (C) 1998 Netscape Communications Corporation. 5 * Portions are Copyright (C) 1998 Netscape Communications Corporation.
6 * 6 *
7 * Other contributors: 7 * Other contributors:
8 * Robert O'Callahan <roc+@cs.cmu.edu> 8 * Robert O'Callahan <roc+@cs.cmu.edu>
9 * David Baron <dbaron@fas.harvard.edu> 9 * David Baron <dbaron@fas.harvard.edu>
10 * Christian Biesinger <cbiesinger@web.de> 10 * Christian Biesinger <cbiesinger@web.de>
(...skipping 222 matching lines...) Expand 10 before | Expand all | Expand 10 after
233 // Does the same as convertToLayerCoords() when not in multicol. For multico l, however, 233 // Does the same as convertToLayerCoords() when not in multicol. For multico l, however,
234 // convertToLayerCoords() calculates the offset in flow-thread coordinates ( what the layout 234 // convertToLayerCoords() calculates the offset in flow-thread coordinates ( what the layout
235 // engine uses internally), while this method calculates the visual coordina tes; i.e. it figures 235 // engine uses internally), while this method calculates the visual coordina tes; i.e. it figures
236 // out which column the layer starts in and adds in the offset. See 236 // out which column the layer starts in and adds in the offset. See
237 // http://www.chromium.org/developers/design-documents/multi-column-layout f or more info. 237 // http://www.chromium.org/developers/design-documents/multi-column-layout f or more info.
238 LayoutPoint visualOffsetFromAncestor(const DeprecatedPaintLayer* ancestorLay er) const; 238 LayoutPoint visualOffsetFromAncestor(const DeprecatedPaintLayer* ancestorLay er) const;
239 239
240 // The hitTest() method looks for mouse events by walking layers that inters ect the point from front to back. 240 // The hitTest() method looks for mouse events by walking layers that inters ect the point from front to back.
241 bool hitTest(HitTestResult&); 241 bool hitTest(HitTestResult&);
242 242
243 // Pass offsetFromRoot if known. 243 bool intersectsDamageRect(const LayoutRect& layerBounds, const LayoutRect& d amageRect, const LayoutPoint& offsetFromRoot) const;
244 bool intersectsDamageRect(const LayoutRect& layerBounds, const LayoutRect& d amageRect, const DeprecatedPaintLayer* rootLayer, const LayoutPoint* offsetFromR oot = 0) const;
245 244
246 // Bounding box relative to some ancestor layer. Pass offsetFromRoot if know n. 245 // Bounding box relative to some ancestor layer. Pass offsetFromRoot if know n.
247 LayoutRect physicalBoundingBox(const DeprecatedPaintLayer* ancestorLayer, co nst LayoutPoint* offsetFromRoot = 0) const; 246 LayoutRect physicalBoundingBox(const LayoutPoint& offsetFromRoot) const;
248 LayoutRect physicalBoundingBoxIncludingReflectionAndStackingChildren(const D eprecatedPaintLayer* ancestorLayer, const LayoutPoint& offsetFromRoot) const; 247 LayoutRect physicalBoundingBox(const DeprecatedPaintLayer* ancestorLayer) co nst;
248 LayoutRect physicalBoundingBoxIncludingReflectionAndStackingChildren(const L ayoutPoint& offsetFromRoot) const;
249 LayoutRect fragmentsBoundingBox(const DeprecatedPaintLayer* ancestorLayer) c onst; 249 LayoutRect fragmentsBoundingBox(const DeprecatedPaintLayer* ancestorLayer) c onst;
250 250
251 LayoutRect boundingBoxForCompositingOverlapTest() const; 251 LayoutRect boundingBoxForCompositingOverlapTest() const;
252 252
253 // If true, this layer's children are included in its bounds for overlap tes ting. 253 // If true, this layer's children are included in its bounds for overlap tes ting.
254 // We can't rely on the children's positions if this layer has a filter that could have moved the children's pixels around. 254 // We can't rely on the children's positions if this layer has a filter that could have moved the children's pixels around.
255 bool overlapBoundsIncludeChildren() const { return hasFilter() && layoutObje ct()->style()->filter().hasFilterThatMovesPixels(); } 255 bool overlapBoundsIncludeChildren() const { return hasFilter() && layoutObje ct()->style()->filter().hasFilterThatMovesPixels(); }
256 256
257 // MaybeIncludeTransformForAncestorLayer means that a transform on |ancestor Layer| may be applied to the bounding box, 257 // MaybeIncludeTransformForAncestorLayer means that a transform on |ancestor Layer| may be applied to the bounding box,
258 // in particular if paintsWithTransform() is true. 258 // in particular if paintsWithTransform() is true.
(...skipping 481 matching lines...) Expand 10 before | Expand all | Expand 10 after
740 740
741 } // namespace blink 741 } // namespace blink
742 742
743 #ifndef NDEBUG 743 #ifndef NDEBUG
744 // Outside the WebCore namespace for ease of invocation from gdb. 744 // Outside the WebCore namespace for ease of invocation from gdb.
745 void showLayerTree(const blink::DeprecatedPaintLayer*); 745 void showLayerTree(const blink::DeprecatedPaintLayer*);
746 void showLayerTree(const blink::LayoutObject*); 746 void showLayerTree(const blink::LayoutObject*);
747 #endif 747 #endif
748 748
749 #endif // Layer_h 749 #endif // Layer_h
OLDNEW
« no previous file with comments | « Source/core/layout/LayoutTreeAsText.cpp ('k') | Source/core/paint/DeprecatedPaintLayer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698