x86 validator: Rewrite non-temporal stores into cached memory accesses

x86 validator: Rewrite non-temporal stores into cached memory accesses

 * This rewrites the set of non-temporal store/prefetch instructions
   that are currently used in the Chrome Web Store, and rejects the
   other non-temporal store/prefetch instructions.

 * This adds two sets of tests:

    * src/trusted/validator/validation_rewrite_test.cc checks for
      exact rewrites.
    * tests/validator/rewrite_nontemporals.c tests that the rewritten
      instructions have the expected behaviour.

 * validation_cache_test.cc: Change the instruction used in the test
   case, because "prefetchnta (%{esp,rsp})" is no longer accepted:
   prefetchnta is not allowed at all on x86-32, and it's only allowed
   with a REX prefix on x86-64.

 * This is based on Rui Qiao's change,
   https://codereview.chromium.org/1269113003/, patch set 29.

BUG=https://code.google.com/p/chromium/issues/detail?id=500026
TEST=run_validation_rewrite_test run_rewrite_nontemporals_test run_validation_cache_test

Committed: https://chromium.googlesource.com/native_client/src/native_client/+/3a518c77e47e7e1f0fb65e00e1115103f0e24ba6

[Mark Seaborn, 2016-02-11 20:57:18]

Description was changed from

==========
x86 validator: Rewrite non-temporal instructions

version from rui's patch, patch set 29

BUG=
==========

to

==========
x86 validator: Rewrite non-temporal stores into cached memory accesses

 * This rewrites the set of non-temporal store/prefetch instructions
   that are currently used in the Chrome Web Store, and rejects the
   other non-temporal store/prefetch instructions.

 * This adds two sets of tests:

    * src/trusted/validator/validation_rewrite_test.cc checks for
      exact rewrites.
    * tests/validator/rewrite_nontemporals.c tests that the rewritten
      instructions have the expected behaviour.

 * validation_cache_test.cc: Change the instruction used in the test
   case, because "prefetchnta (%{esp,rsp})" is no longer accepted:
   prefetchnta is not allowed at all on x86-32, and it's only allowed
   with a REX prefix on x86-64.

 * This is based on Rui Qiao's change,
   https://codereview.chromium.org/1269113003/, patch set 29.

BUG=https://code.google.com/p/chromium/issues/detail?id=500026
TEST=run_validation_rewrite_test run_rewrite_nontemporals_test
run_validation_cache_test
==========

[Mark Seaborn, 2016-02-11 20:57:18]

mseaborn@chromium.org changed reviewers:
+ phosek@chromium.org

[Petr Hosek, 2016-02-11 23:59:53]

lgtm

https://codereview.chromium.org/1309953002/diff/180001/tests/validator/rewrit...
File tests/validator/rewrite_nontemporals.c (right):

https://codereview.chromium.org/1309953002/diff/180001/tests/validator/rewrit...
tests/validator/rewrite_nontemporals.c:2: * Copyright (c) 2016 The Native Client
Authors. All rights reserved.
Nit: We're no longer using (c) in the copyright header.

[Mark Seaborn, 2016-02-12 00:32:19]

https://codereview.chromium.org/1309953002/diff/180001/tests/validator/rewrit...
File tests/validator/rewrite_nontemporals.c (right):

https://codereview.chromium.org/1309953002/diff/180001/tests/validator/rewrit...
tests/validator/rewrite_nontemporals.c:2: * Copyright (c) 2016 The Native Client
Authors. All rights reserved.
On 2016/02/11 23:59:53, Petr Hosek wrote:
> Nit: We're no longer using (c) in the copyright header.

Done.

[Mark Seaborn, 2016-02-12 00:32:29]

The CQ bit was checked by mseaborn@chromium.org

[Mark Seaborn, 2016-02-12 00:32:30]

The patchset sent to the CQ was uploaded after l-g-t-m from phosek@chromium.org
Link to the patchset: https://codereview.chromium.org/1309953002/#ps200001
(title: "Review nit")

[commit-bot: I haz the power, 2016-02-12 00:32:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1309953002/200001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1309953002/200001

[commit-bot: I haz the power, 2016-02-12 01:25:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-12 01:25:03]

Failed to request the patch to try. Please note that binary files are still
unsupported at the moment, this is being worked on.

Thanks for your patience.

Transient error: No JSON object could be decoded

[Mark Seaborn, 2016-02-12 02:06:45]

The CQ bit was checked by mseaborn@chromium.org

[commit-bot: I haz the power, 2016-02-12 02:06:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1309953002/200001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1309953002/200001

[commit-bot: I haz the power, 2016-02-12 02:07:46]

Description was changed from

==========
x86 validator: Rewrite non-temporal stores into cached memory accesses

 * This rewrites the set of non-temporal store/prefetch instructions
   that are currently used in the Chrome Web Store, and rejects the
   other non-temporal store/prefetch instructions.

 * This adds two sets of tests:

    * src/trusted/validator/validation_rewrite_test.cc checks for
      exact rewrites.
    * tests/validator/rewrite_nontemporals.c tests that the rewritten
      instructions have the expected behaviour.

 * validation_cache_test.cc: Change the instruction used in the test
   case, because "prefetchnta (%{esp,rsp})" is no longer accepted:
   prefetchnta is not allowed at all on x86-32, and it's only allowed
   with a REX prefix on x86-64.

 * This is based on Rui Qiao's change,
   https://codereview.chromium.org/1269113003/, patch set 29.

BUG=https://code.google.com/p/chromium/issues/detail?id=500026
TEST=run_validation_rewrite_test run_rewrite_nontemporals_test
run_validation_cache_test
==========

to

==========
x86 validator: Rewrite non-temporal stores into cached memory accesses

 * This rewrites the set of non-temporal store/prefetch instructions
   that are currently used in the Chrome Web Store, and rejects the
   other non-temporal store/prefetch instructions.

 * This adds two sets of tests:

    * src/trusted/validator/validation_rewrite_test.cc checks for
      exact rewrites.
    * tests/validator/rewrite_nontemporals.c tests that the rewritten
      instructions have the expected behaviour.

 * validation_cache_test.cc: Change the instruction used in the test
   case, because "prefetchnta (%{esp,rsp})" is no longer accepted:
   prefetchnta is not allowed at all on x86-32, and it's only allowed
   with a REX prefix on x86-64.

 * This is based on Rui Qiao's change,
   https://codereview.chromium.org/1269113003/, patch set 29.

BUG=https://code.google.com/p/chromium/issues/detail?id=500026
TEST=run_validation_rewrite_test run_rewrite_nontemporals_test
run_validation_cache_test

Committed:
https://chromium.googlesource.com/native_client/src/native_client/+/3a518c77e...
==========

[commit-bot: I haz the power, 2016-02-12 02:07:47]

Committed patchset #11 (id:200001) as
https://chromium.googlesource.com/native_client/src/native_client/+/3a518c77e...

[Mark Seaborn, 2016-02-12 20:30:53]

I noticed this caused some failures in the toolchain torture tests on the
toolchain FYI bots:

https://build.chromium.org/p/client.nacl.toolchain/builders/linux-pnacl-x86_6...
https://build.chromium.org/p/client.nacl.toolchain/builders/linux-pnacl-x86_6...

Basically some tests for __builtin_prefetch() are generating "prefetchnta"
(documented here:
https://gcc.gnu.org/onlinedocs/gcc-3.3.6/gcc/Other-Builtins.html).

I'll fix that by changing the validator to rewrite more cases.