Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1099)

Unified Diff: src/trusted/validator/validation_cache_test.cc

Issue 1309953002: x86 validator: Rewrite non-temporal stores into cached memory accesses (Closed) Base URL: https://chromium.googlesource.com/native_client/src/native_client.git@master
Patch Set: Review nit Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/trusted/validator/build.scons ('k') | src/trusted/validator/validation_disable_nontemporals_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/trusted/validator/validation_cache_test.cc
diff --git a/src/trusted/validator/validation_cache_test.cc b/src/trusted/validator/validation_cache_test.cc
index 19b8c8c9ec2c6d35e388764adb5128e2be44a4e2..7fbadca40f797a450e64dc4e6a4374a430a8b97a 100644
--- a/src/trusted/validator/validation_cache_test.cc
+++ b/src/trusted/validator/validation_cache_test.cc
@@ -49,7 +49,14 @@ const uint8_t sse41[] =
const uint8_t sse41_plus_nontemporal[] =
{ 0x66, 0x0f, 0x3a, 0x0e, 0xd0, 0xc0, // pblendw $0xc0,%xmm0,%xmm2
- 0x0f, 0x18, 0x04, 0x24 }; // prefetchnta (%rsp)
+ // Example of a non-temporal instruction that is rewritten without
+ // being rejected entirely.
+#if NACL_BUILD_SUBARCH == 32
+ 0x66, 0x0f, 0xe7, 0x04, 0x24 // movntdq %xmm0,(%esp)
+#else
+ 0x66, 0x41, 0x0f, 0xe7, 0x07 // movntdq %xmm0,(%r15)
+#endif
+ };
// Example of a valid JMP to outside the bundle, in a bundle containing an
// instruction that gets stubbed out.
« no previous file with comments | « src/trusted/validator/build.scons ('k') | src/trusted/validator/validation_disable_nontemporals_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698