Fix cpplint errors in cc/(animation|input|layers|trees|test)/

Fix cpplint errors in cc/(animation|input|layers|trees|test)/

This fixes lint errors in everything except for the few stragglers (occlusion unit test, etc) that haven't been chromified.

BUG=144577
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190767

[jamesr, 2013-03-25 07:51:46]

I skipped cc/trees/*occlusion*unittest*, but otherwise everything lints very
nearly clean.  There are a handful of bugs in the linter itself but nothing
major.

[enne (OOO), 2013-03-25 17:01:27]

lgtm, cq+

What sort of bugs in the linter? Will they prevent us from presubmit linting?

[commit-bot: I haz the power, 2013-03-25 17:01:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamesr@chromium.org/12965007/1

[jamesr, 2013-03-25 17:38:20]

On 2013/03/25 17:01:36, I haz the power (commit-bot) wrote:
> CQ is trying da patch. Follow status at
> https://chromium-status.appspot.com/cq/jamesr%40chromium.org/12965007/1

Dies on windows:

FAILED: ninja -t msvc -o
obj\cc\test\cc_test_support.fake_layer_tree_host_client.obj -e environment.x86
-- E:\b\build\goma\gomacc.exe cl.exe /nologo /showIncludes /FC
@obj\cc\test\cc_test_support.fake_layer_tree_host_client.obj.rsp /c
..\..\cc\test\fake_layer_tree_host_client.cc
/Foobj\cc\test\cc_test_support.fake_layer_tree_host_client.obj
/Fdobj\cc\cc_test_support.pdb 
e:\b\build\slave\win\build\src\cc\trees\layer_tree_host.h(81) :error C2220:
warning treated as error - no 'object' file generated

e:\b\build\slave\win\build\src\cc\trees\layer_tree_host.h(81) : warning C4275:
non dll-interface class 'cc::RateLimiterClient' used as base for dll-interface
class 'cc::LayerTreeHost'

        e:\b\build\slave\win\build\src\cc\scheduler\rate_limiter.h(16) : see
declaration of 'cc::RateLimiterClient'

        e:\b\build\slave\win\build\src\cc\trees\layer_tree_host.h(81) : see
declaration of 'cc::LayerTreeHost'

adding the virtual destructor to RateLimitClient triggers this warning.  Need
more NON_EXPORTED_BASE

[commit-bot: I haz the power, 2013-03-25 18:14:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamesr@chromium.org/12965007/17001

[commit-bot: I haz the power, 2013-03-26 07:09:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamesr@chromium.org/12965007/17001

[commit-bot: I haz the power, 2013-03-26 10:01:15]

Failed to apply patch for cc/layers/append_quads_data.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file cc/layers/append_quads_data.h
  Hunk #1 FAILED at 11.
  1 out of 1 hunk FAILED -- saving rejects to file
cc/layers/append_quads_data.h.rej

Patch:       cc/layers/append_quads_data.h
Index: cc/layers/append_quads_data.h
diff --git a/cc/layers/append_quads_data.h b/cc/layers/append_quads_data.h
index
18580a9b54cbdabefc00d454cb6c23842cf2620f..acc12989a97dba54c72e522fd82e4e6072d19e50
100644
--- a/cc/layers/append_quads_data.h
+++ b/cc/layers/append_quads_data.h
@@ -11,31 +11,27 @@
 namespace cc {
 
 struct AppendQuadsData {
-    AppendQuadsData()
-        : hadOcclusionFromOutsideTargetSurface(false)
-        , hadIncompleteTile(false)
-        , numMissingTiles(0)
-        , renderPassId(0, 0)
-    {
-    }
+  AppendQuadsData()
+    : hadOcclusionFromOutsideTargetSurface(false),
+      hadIncompleteTile(false),
+      numMissingTiles(0),
+      renderPassId(0, 0) {}
 
-    explicit AppendQuadsData(RenderPass::Id renderPassId)
-        : hadOcclusionFromOutsideTargetSurface(false)
-        , hadIncompleteTile(false)
-        , numMissingTiles(0)
-        , renderPassId(renderPassId)
-    {
-    }
+  explicit AppendQuadsData(RenderPass::Id renderPassId)
+    : hadOcclusionFromOutsideTargetSurface(false),
+      hadIncompleteTile(false),
+      numMissingTiles(0),
+      renderPassId(renderPassId) {}
 
-    // Set by the QuadCuller.
-    bool hadOcclusionFromOutsideTargetSurface;
-    // Set by the layer appending quads.
-    bool hadIncompleteTile;
-    // Set by the layer appending quads.
-    int64 numMissingTiles;
-    // Given to the layer appending quads.
-    const RenderPass::Id renderPassId;
+  // Set by the QuadCuller.
+  bool hadOcclusionFromOutsideTargetSurface;
+  // Set by the layer appending quads.
+  bool hadIncompleteTile;
+  // Set by the layer appending quads.
+  int64 numMissingTiles;
+  // Given to the layer appending quads.
+  const RenderPass::Id renderPassId;
 };
 
-}
+}  // namespace cc
 #endif  // CC_LAYERS_APPEND_QUADS_DATA_H_

[danakj, 2013-03-26 15:04:07]

On Tue, Mar 26, 2013 at 6:01 AM, <commit-bot@chromium.org> wrote:

> Failed to apply patch for cc/layers/append_quads_data.h:
>
> Oh darn, I skipped over the file I remembered this touched. Forgot that it
hit this one too.

[commit-bot: I haz the power, 2013-03-26 18:20:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamesr@chromium.org/12965007/39001

[commit-bot: I haz the power, 2013-03-26 21:15:08]

Change committed as 190767