Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2758)

Unified Diff: cc/layers/picture_layer_impl.cc

Issue 12965007: Fix cpplint errors in cc/(animation|input|layers|trees|test)/ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebased Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/layers/picture_layer_impl.h ('k') | cc/layers/picture_layer_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/layers/picture_layer_impl.cc
diff --git a/cc/layers/picture_layer_impl.cc b/cc/layers/picture_layer_impl.cc
index 8e0d06ff8b0ad080cbcd0e4b6787693e85e3c883..9d456fc3b65d50e0a2b54a52e098d6ecd2012d2b 100644
--- a/cc/layers/picture_layer_impl.cc
+++ b/cc/layers/picture_layer_impl.cc
@@ -4,6 +4,8 @@
#include "cc/layers/picture_layer_impl.h"
+#include <algorithm>
+
#include "base/time.h"
#include "cc/base/math_util.h"
#include "cc/base/util.h"
@@ -154,7 +156,6 @@ void PictureLayerImpl::AppendQuads(QuadSink* quad_sink,
ideal_contents_scale_);
iter;
++iter) {
-
gfx::Rect geometry_rect = iter.geometry_rect();
if (!*iter || !iter->drawing_info().IsReadyToDraw()) {
if (DrawCheckerboardForMissingTiles()) {
@@ -207,7 +208,7 @@ void PictureLayerImpl::AppendQuads(QuadSink* quad_sink,
case ManagedTileState::DrawingInfo::TRANSPARENT_MODE:
break;
case ManagedTileState::DrawingInfo::PICTURE_PILE_MODE:
- // TODO: crbug.com/173011 would fill this part in.
+ // TODO(leandrogarcia): crbug.com/173011 would fill this part in.
default:
NOTREACHED();
}
@@ -576,8 +577,8 @@ void PictureLayerImpl::RemoveTiling(float contents_scale) {
namespace {
inline float PositiveRatio(float float1, float float2) {
- DCHECK(float1 > 0);
- DCHECK(float2 > 0);
+ DCHECK_GT(float1, 0);
+ DCHECK_GT(float2, 0);
return float1 > float2 ? float1 / float2 : float2 / float1;
}
« no previous file with comments | « cc/layers/picture_layer_impl.h ('k') | cc/layers/picture_layer_impl_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698