Fix cpplint errors in cc/(animation|input|layers|trees|test)/

cc/trees/quad_culler_unittest.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/trees/quad_culler.h"
 
+#include <vector>
+
 #include "cc/base/math_util.h"
 #include "cc/debug/overdraw_metrics.h"
 #include "cc/layers/append_quads_data.h"
 #include "cc/layers/tiled_layer_impl.h"
 #include "cc/quads/tile_draw_quad.h"
 #include "cc/resources/layer_tiling_data.h"
 #include "cc/test/fake_impl_proxy.h"
 #include "cc/test/fake_layer_tree_host_impl.h"
 #include "cc/trees/occlusion_tracker.h"
 #include "cc/trees/single_thread_proxy.h"
@@ skipping 80 matching lines @@
       parent->render_surface()->layer_list().push_back(layer.get());
       rect_in_target.Union(MathUtil::MapClippedRect(
           parent->draw_transform(), parent->visible_content_rect()));
       parent->render_surface()->SetContentRect(rect_in_target);
     }
     layer->draw_properties().drawable_content_rect = rect_in_target;
 
     return layer.Pass();
   }
 
-  void AppendQuads(QuadList& quad_list,
+  void AppendQuads(QuadList* quad_list,
                    SharedQuadStateList& shared_state_list,
                    TiledLayerImpl* layer,
                    LayerIteratorType& it,
                    OcclusionTrackerImpl& occlusion_tracker) {
     occlusion_tracker.EnterLayer(it);
     QuadCuller quad_culler(
-        &quad_list, &shared_state_list, layer, occlusion_tracker, false, false);
+        quad_list, &shared_state_list, layer, occlusion_tracker, false, false);
     AppendQuadsData data;
     layer->AppendQuads(&quad_culler, &data);
     occlusion_tracker.LeaveLayer(it);
     ++it;
   }
 
  protected:
   FakeImplProxy proxy_;
   FakeLayerTreeHostImpl host_impl_;
   int layer_id_;
@@ skipping 26 matching lines @@
                                                      gfx::Transform(),
                                                      child_rect,
                                                      1,
                                                      false,
                                                      gfx::Rect(),
                                                      render_surface_layer_list);
   TestOcclusionTrackerImpl occlusion_tracker(gfx::Rect(-100, -100, 1000, 1000));
   LayerIteratorType it = LayerIteratorType::Begin(&render_surface_layer_list);
 
   AppendQuads(
-      quad_list, shared_state_list, child_layer.get(), it, occlusion_tracker);
+      &quad_list, shared_state_list, child_layer.get(), it, occlusion_tracker);
   AppendQuads(
-      quad_list, shared_state_list, root_layer.get(), it, occlusion_tracker);
+      &quad_list, shared_state_list, root_layer.get(), it, occlusion_tracker);
   EXPECT_EQ(quad_list.size(), 13u);
   EXPECT_NEAR(
       occlusion_tracker.overdraw_metrics()->pixels_drawn_opaque(), 90000, 1);
   EXPECT_NEAR(occlusion_tracker.overdraw_metrics()->pixels_drawn_translucent(),
               40000,
               1);
   EXPECT_NEAR(
       occlusion_tracker.overdraw_metrics()->pixels_culled_for_drawing(), 0, 1);
 }
 
@@ skipping 12 matching lines @@
                                                      gfx::Transform(),
                                                      child_rect,
                                                      1,
                                                      true,
                                                      gfx::Rect(),
                                                      render_surface_layer_list);
   TestOcclusionTrackerImpl occlusion_tracker(gfx::Rect(-100, -100, 1000, 1000));
   LayerIteratorType it = LayerIteratorType::Begin(&render_surface_layer_list);
 
   AppendQuads(
-      quad_list, shared_state_list, child_layer.get(), it, occlusion_tracker);
+      &quad_list, shared_state_list, child_layer.get(), it, occlusion_tracker);
   AppendQuads(
-      quad_list, shared_state_list, root_layer.get(), it, occlusion_tracker);
+      &quad_list, shared_state_list, root_layer.get(), it, occlusion_tracker);
   EXPECT_EQ(quad_list.size(), 9u);
   EXPECT_NEAR(
       occlusion_tracker.overdraw_metrics()->pixels_drawn_opaque(), 90000, 1);
   EXPECT_NEAR(
       occlusion_tracker.overdraw_metrics()->pixels_drawn_translucent(), 0, 1);
   EXPECT_NEAR(occlusion_tracker.overdraw_metrics()->pixels_culled_for_drawing(),
               40000,
               1);
 }
 
@@ skipping 12 matching lines @@
                                                      child_transform,
                                                      child_rect,
                                                      0.9f,
                                                      true,
                                                      gfx::Rect(),
                                                      render_surface_layer_list);
   TestOcclusionTrackerImpl occlusion_tracker(gfx::Rect(-100, -100, 1000, 1000));
   LayerIteratorType it = LayerIteratorType::Begin(&render_surface_layer_list);
 
   AppendQuads(
-      quad_list, shared_state_list, child_layer.get(), it, occlusion_tracker);
+      &quad_list, shared_state_list, child_layer.get(), it, occlusion_tracker);
   AppendQuads(
-      quad_list, shared_state_list, root_layer.get(), it, occlusion_tracker);
+      &quad_list, shared_state_list, root_layer.get(), it, occlusion_tracker);
   EXPECT_EQ(quad_list.size(), 13u);
   EXPECT_NEAR(
       occlusion_tracker.overdraw_metrics()->pixels_drawn_opaque(), 90000, 1);
   EXPECT_NEAR(occlusion_tracker.overdraw_metrics()->pixels_drawn_translucent(),
               40000,
               1);
   EXPECT_NEAR(
       occlusion_tracker.overdraw_metrics()->pixels_culled_for_drawing(), 0, 1);
 }
 
@@ skipping 12 matching lines @@
                                                      child_transform,
                                                      child_rect,
                                                      1,
                                                      false,
                                                      gfx::Rect(),
                                                      render_surface_layer_list);
   TestOcclusionTrackerImpl occlusion_tracker(gfx::Rect(-100, -100, 1000, 1000));
   LayerIteratorType it = LayerIteratorType::Begin(&render_surface_layer_list);
 
   AppendQuads(
-      quad_list, shared_state_list, child_layer.get(), it, occlusion_tracker);
+      &quad_list, shared_state_list, child_layer.get(), it, occlusion_tracker);
   AppendQuads(
-      quad_list, shared_state_list, root_layer.get(), it, occlusion_tracker);
+      &quad_list, shared_state_list, root_layer.get(), it, occlusion_tracker);
   EXPECT_EQ(quad_list.size(), 13u);
   EXPECT_NEAR(
       occlusion_tracker.overdraw_metrics()->pixels_drawn_opaque(), 90000, 1);
   EXPECT_NEAR(occlusion_tracker.overdraw_metrics()->pixels_drawn_translucent(),
               40000,
               1);
   EXPECT_NEAR(
       occlusion_tracker.overdraw_metrics()->pixels_culled_for_drawing(), 0, 1);
 }
 
@@ skipping 12 matching lines @@
                                                      child_transform,
                                                      child_rect,
                                                      1,
                                                      true,
                                                      gfx::Rect(),
                                                      render_surface_layer_list);
   TestOcclusionTrackerImpl occlusion_tracker(gfx::Rect(-100, -100, 1000, 1000));
   LayerIteratorType it = LayerIteratorType::Begin(&render_surface_layer_list);
 
   AppendQuads(
-      quad_list, shared_state_list, child_layer.get(), it, occlusion_tracker);
+      &quad_list, shared_state_list, child_layer.get(), it, occlusion_tracker);
   AppendQuads(
-      quad_list, shared_state_list, root_layer.get(), it, occlusion_tracker);
+      &quad_list, shared_state_list, root_layer.get(), it, occlusion_tracker);
   ASSERT_EQ(quad_list.size(), 12u);
 
   gfx::Rect quad_visible_rect1 = quad_list[5]->visible_rect;
   EXPECT_EQ(quad_visible_rect1.height(), 50);
 
   gfx::Rect quad_visible_rect3 = quad_list[7]->visible_rect;
   EXPECT_EQ(quad_visible_rect3.width(), 50);
 
   // Next index is 8, not 9, since centre quad culled.
   gfx::Rect quad_visible_rect4 = quad_list[8]->visible_rect;
@@ skipping 37 matching lines @@
                                                      child_transform,
                                                      child_rect,
                                                      1,
                                                      true,
                                                      gfx::Rect(),
                                                      render_surface_layer_list);
   TestOcclusionTrackerImpl occlusion_tracker(gfx::Rect(-100, -100, 1000, 1000));
   LayerIteratorType it = LayerIteratorType::Begin(&render_surface_layer_list);
 
   AppendQuads(
-      quad_list, shared_state_list, child_layer.get(), it, occlusion_tracker);
+      &quad_list, shared_state_list, child_layer.get(), it, occlusion_tracker);
   AppendQuads(
-      quad_list, shared_state_list, root_layer.get(), it, occlusion_tracker);
+      &quad_list, shared_state_list, root_layer.get(), it, occlusion_tracker);
   EXPECT_EQ(quad_list.size(), 2u);
 
   EXPECT_NEAR(
       occlusion_tracker.overdraw_metrics()->pixels_drawn_opaque(), 20363, 1);
   EXPECT_NEAR(
       occlusion_tracker.overdraw_metrics()->pixels_drawn_translucent(), 0, 1);
   EXPECT_NEAR(
       occlusion_tracker.overdraw_metrics()->pixels_culled_for_drawing(), 0, 1);
 }
 
@@ skipping 22 matching lines @@
                                                      child_transform,
                                                      child_rect,
                                                      1,
                                                      true,
                                                      gfx::Rect(),
                                                      render_surface_layer_list);
   TestOcclusionTrackerImpl occlusion_tracker(gfx::Rect(-100, -100, 1000, 1000));
   LayerIteratorType it = LayerIteratorType::Begin(&render_surface_layer_list);
 
   AppendQuads(
-      quad_list, shared_state_list, child_layer.get(), it, occlusion_tracker);
+      &quad_list, shared_state_list, child_layer.get(), it, occlusion_tracker);
   AppendQuads(
-      quad_list, shared_state_list, root_layer.get(), it, occlusion_tracker);
+      &quad_list, shared_state_list, root_layer.get(), it, occlusion_tracker);
   EXPECT_EQ(quad_list.size(), 2u);
 
   EXPECT_NEAR(
       occlusion_tracker.overdraw_metrics()->pixels_drawn_opaque(), 19643, 1);
   EXPECT_NEAR(
       occlusion_tracker.overdraw_metrics()->pixels_drawn_translucent(), 0, 1);
   EXPECT_NEAR(
       occlusion_tracker.overdraw_metrics()->pixels_culled_for_drawing(), 0, 1);
 }
 
@@ skipping 12 matching lines @@
                                                      child_transform,
                                                      child_rect,
                                                      1,
                                                      true,
                                                      gfx::Rect(),
                                                      render_surface_layer_list);
   TestOcclusionTrackerImpl occlusion_tracker(gfx::Rect(-100, -100, 1000, 1000));
   LayerIteratorType it = LayerIteratorType::Begin(&render_surface_layer_list);
 
   AppendQuads(
-      quad_list, shared_state_list, child_layer.get(), it, occlusion_tracker);
+      &quad_list, shared_state_list, child_layer.get(), it, occlusion_tracker);
   AppendQuads(
-      quad_list, shared_state_list, root_layer.get(), it, occlusion_tracker);
+      &quad_list, shared_state_list, root_layer.get(), it, occlusion_tracker);
   EXPECT_EQ(quad_list.size(), 9u);
   EXPECT_NEAR(
       occlusion_tracker.overdraw_metrics()->pixels_drawn_opaque(), 90000, 1);
   EXPECT_NEAR(
       occlusion_tracker.overdraw_metrics()->pixels_drawn_translucent(), 0, 1);
   EXPECT_NEAR(occlusion_tracker.overdraw_metrics()->pixels_culled_for_drawing(),
               40000,
               1);
 }
 
@@ skipping 16 matching lines @@
                                                      child_transform,
                                                      child_rect,
                                                      1,
                                                      false,
                                                      child_opaque_rect,
                                                      render_surface_layer_list);
   TestOcclusionTrackerImpl occlusion_tracker(gfx::Rect(-100, -100, 1000, 1000));
   LayerIteratorType it = LayerIteratorType::Begin(&render_surface_layer_list);
 
   AppendQuads(
-      quad_list, shared_state_list, child_layer.get(), it, occlusion_tracker);
+      &quad_list, shared_state_list, child_layer.get(), it, occlusion_tracker);
   AppendQuads(
-      quad_list, shared_state_list, root_layer.get(), it, occlusion_tracker);
+      &quad_list, shared_state_list, root_layer.get(), it, occlusion_tracker);
   EXPECT_EQ(quad_list.size(), 12u);
   EXPECT_NEAR(
       occlusion_tracker.overdraw_metrics()->pixels_drawn_opaque(), 90000, 1);
   EXPECT_NEAR(occlusion_tracker.overdraw_metrics()->pixels_drawn_translucent(),
               30000,
               1);
   EXPECT_NEAR(occlusion_tracker.overdraw_metrics()->pixels_culled_for_drawing(),
               10000,
               1);
 }
@@ skipping 17 matching lines @@
                                                      child_transform,
                                                      child_rect,
                                                      1,
                                                      false,
                                                      child_opaque_rect,
                                                      render_surface_layer_list);
   TestOcclusionTrackerImpl occlusion_tracker(gfx::Rect(-100, -100, 1000, 1000));
   LayerIteratorType it = LayerIteratorType::Begin(&render_surface_layer_list);
 
   AppendQuads(
-      quad_list, shared_state_list, child_layer.get(), it, occlusion_tracker);
+      &quad_list, shared_state_list, child_layer.get(), it, occlusion_tracker);
   AppendQuads(
-      quad_list, shared_state_list, root_layer.get(), it, occlusion_tracker);
+      &quad_list, shared_state_list, root_layer.get(), it, occlusion_tracker);
   EXPECT_EQ(quad_list.size(), 12u);
   EXPECT_NEAR(
       occlusion_tracker.overdraw_metrics()->pixels_drawn_opaque(), 90000, 1);
   EXPECT_NEAR(occlusion_tracker.overdraw_metrics()->pixels_drawn_translucent(),
               25000,
               1);
   EXPECT_NEAR(occlusion_tracker.overdraw_metrics()->pixels_culled_for_drawing(),
               15000,
               1);
 }
@@ skipping 17 matching lines @@
                                                      child_transform,
                                                      child_rect,
                                                      1,
                                                      false,
                                                      child_opaque_rect,
                                                      render_surface_layer_list);
   TestOcclusionTrackerImpl occlusion_tracker(gfx::Rect(-100, -100, 1000, 1000));
   LayerIteratorType it = LayerIteratorType::Begin(&render_surface_layer_list);
 
   AppendQuads(
-      quad_list, shared_state_list, child_layer.get(), it, occlusion_tracker);
+      &quad_list, shared_state_list, child_layer.get(), it, occlusion_tracker);
   AppendQuads(
-      quad_list, shared_state_list, root_layer.get(), it, occlusion_tracker);
+      &quad_list, shared_state_list, root_layer.get(), it, occlusion_tracker);
   EXPECT_EQ(quad_list.size(), 13u);
   EXPECT_NEAR(
       occlusion_tracker.overdraw_metrics()->pixels_drawn_opaque(), 90000, 1);
   EXPECT_NEAR(occlusion_tracker.overdraw_metrics()->pixels_drawn_translucent(),
               30000,
               1);
   EXPECT_NEAR(occlusion_tracker.overdraw_metrics()->pixels_culled_for_drawing(),
               10000,
               1);
 }
@@ skipping 15 matching lines @@
                                                      child_transform,
                                                      child_rect,
                                                      1,
                                                      true,
                                                      gfx::Rect(),
                                                      render_surface_layer_list);
   TestOcclusionTrackerImpl occlusion_tracker(gfx::Rect(-100, -100, 1000, 1000));
   LayerIteratorType it = LayerIteratorType::Begin(&render_surface_layer_list);
 
   AppendQuads(
-      quad_list, shared_state_list, child_layer.get(), it, occlusion_tracker);
+      &quad_list, shared_state_list, child_layer.get(), it, occlusion_tracker);
   AppendQuads(
-      quad_list, shared_state_list, root_layer.get(), it, occlusion_tracker);
+      &quad_list, shared_state_list, root_layer.get(), it, occlusion_tracker);
   EXPECT_EQ(quad_list.size(), 13u);
   EXPECT_NEAR(
       occlusion_tracker.overdraw_metrics()->pixels_drawn_opaque(), 130000, 1);
   EXPECT_NEAR(
       occlusion_tracker.overdraw_metrics()->pixels_drawn_translucent(), 0, 1);
   EXPECT_NEAR(
       occlusion_tracker.overdraw_metrics()->pixels_culled_for_drawing(), 0, 1);
 }
 
 // This test requires some explanation: here we are rotating the quads to be
@@ skipping 20 matching lines @@
                                                      gfx::Transform(),
                                                      child_rect,
                                                      1,
                                                      true,
                                                      gfx::Rect(),
                                                      render_surface_layer_list);
   TestOcclusionTrackerImpl occlusion_tracker(gfx::Rect(-100, -100, 1000, 1000));
   LayerIteratorType it = LayerIteratorType::Begin(&render_surface_layer_list);
 
   AppendQuads(
-      quad_list, shared_state_list, child_layer.get(), it, occlusion_tracker);
+      &quad_list, shared_state_list, child_layer.get(), it, occlusion_tracker);
   AppendQuads(
-      quad_list, shared_state_list, root_layer.get(), it, occlusion_tracker);
+      &quad_list, shared_state_list, root_layer.get(), it, occlusion_tracker);
   EXPECT_EQ(quad_list.size(), 12u);
   EXPECT_NEAR(
       occlusion_tracker.overdraw_metrics()->pixels_drawn_opaque(), 100600, 1);
   EXPECT_NEAR(
       occlusion_tracker.overdraw_metrics()->pixels_drawn_translucent(), 0, 1);
   EXPECT_NEAR(occlusion_tracker.overdraw_metrics()->pixels_culled_for_drawing(),
               29400,
               1);
 }
 
@@ skipping 11 matching lines @@
                                                      gfx::Transform(),
                                                      child_rect,
                                                      1,
                                                      true,
                                                      gfx::Rect(),
                                                      render_surface_layer_list);
   TestOcclusionTrackerImpl occlusion_tracker(gfx::Rect(200, 100, 100, 100));
   LayerIteratorType it = LayerIteratorType::Begin(&render_surface_layer_list);
 
   AppendQuads(
-      quad_list, shared_state_list, child_layer.get(), it, occlusion_tracker);
+      &quad_list, shared_state_list, child_layer.get(), it, occlusion_tracker);
   AppendQuads(
-      quad_list, shared_state_list, root_layer.get(), it, occlusion_tracker);
+      &quad_list, shared_state_list, root_layer.get(), it, occlusion_tracker);
   EXPECT_EQ(quad_list.size(), 1u);
   EXPECT_NEAR(
       occlusion_tracker.overdraw_metrics()->pixels_drawn_opaque(), 10000, 1);
   EXPECT_NEAR(
       occlusion_tracker.overdraw_metrics()->pixels_drawn_translucent(), 0, 1);
   EXPECT_NEAR(occlusion_tracker.overdraw_metrics()->pixels_culled_for_drawing(),
               120000,
               1);
 }
 
@@ skipping 11 matching lines @@
                                                      gfx::Transform(),
                                                      child_rect,
                                                      1,
                                                      true,
                                                      gfx::Rect(),
                                                      render_surface_layer_list);
   TestOcclusionTrackerImpl occlusion_tracker(gfx::Rect(100, 100, 100, 100));
   LayerIteratorType it = LayerIteratorType::Begin(&render_surface_layer_list);
 
   AppendQuads(
-      quad_list, shared_state_list, child_layer.get(), it, occlusion_tracker);
+      &quad_list, shared_state_list, child_layer.get(), it, occlusion_tracker);
   AppendQuads(
-      quad_list, shared_state_list, root_layer.get(), it, occlusion_tracker);
+      &quad_list, shared_state_list, root_layer.get(), it, occlusion_tracker);
   EXPECT_EQ(quad_list.size(), 1u);
   EXPECT_NEAR(
       occlusion_tracker.overdraw_metrics()->pixels_drawn_opaque(), 10000, 1);
   EXPECT_NEAR(
       occlusion_tracker.overdraw_metrics()->pixels_drawn_translucent(), 0, 1);
   EXPECT_NEAR(occlusion_tracker.overdraw_metrics()->pixels_culled_for_drawing(),
               120000,
               1);
 }
 
@@ skipping 11 matching lines @@
                                                      gfx::Transform(),
                                                      child_rect,
                                                      1,
                                                      true,
                                                      gfx::Rect(),
                                                      render_surface_layer_list);
   TestOcclusionTrackerImpl occlusion_tracker(gfx::Rect(50, 50, 200, 200));
   LayerIteratorType it = LayerIteratorType::Begin(&render_surface_layer_list);
 
   AppendQuads(
-      quad_list, shared_state_list, child_layer.get(), it, occlusion_tracker);
+      &quad_list, shared_state_list, child_layer.get(), it, occlusion_tracker);
   AppendQuads(
-      quad_list, shared_state_list, root_layer.get(), it, occlusion_tracker);
+      &quad_list, shared_state_list, root_layer.get(), it, occlusion_tracker);
   EXPECT_EQ(quad_list.size(), 9u);
   EXPECT_NEAR(
       occlusion_tracker.overdraw_metrics()->pixels_drawn_opaque(), 40000, 1);
   EXPECT_NEAR(
       occlusion_tracker.overdraw_metrics()->pixels_drawn_translucent(), 0, 1);
   EXPECT_NEAR(occlusion_tracker.overdraw_metrics()->pixels_culled_for_drawing(),
               90000,
               1);
 }
 
@@ skipping 11 matching lines @@
                                                      gfx::Transform(),
                                                      child_rect,
                                                      1,
                                                      true,
                                                      gfx::Rect(),
                                                      render_surface_layer_list);
   TestOcclusionTrackerImpl occlusion_tracker(gfx::Rect(500, 500, 100, 100));
   LayerIteratorType it = LayerIteratorType::Begin(&render_surface_layer_list);
 
   AppendQuads(
-      quad_list, shared_state_list, child_layer.get(), it, occlusion_tracker);
+      &quad_list, shared_state_list, child_layer.get(), it, occlusion_tracker);
   AppendQuads(
-      quad_list, shared_state_list, root_layer.get(), it, occlusion_tracker);
+      &quad_list, shared_state_list, root_layer.get(), it, occlusion_tracker);
   EXPECT_EQ(quad_list.size(), 0u);
   EXPECT_NEAR(
       occlusion_tracker.overdraw_metrics()->pixels_drawn_opaque(), 0, 1);
   EXPECT_NEAR(
       occlusion_tracker.overdraw_metrics()->pixels_drawn_translucent(), 0, 1);
   EXPECT_NEAR(occlusion_tracker.overdraw_metrics()->pixels_culled_for_drawing(),
               130000,
               1);
 }
 
@@ skipping 12 matching lines @@
                                                      child_rect,
                                                      1,
                                                      true,
                                                      gfx::Rect(),
                                                      render_surface_layer_list);
   TestOcclusionTrackerImpl occlusion_tracker(gfx::Rect(50, 50, 200, 200),
                                              false);
   LayerIteratorType it = LayerIteratorType::Begin(&render_surface_layer_list);
 
   AppendQuads(
-      quad_list, shared_state_list, child_layer.get(), it, occlusion_tracker);
+      &quad_list, shared_state_list, child_layer.get(), it, occlusion_tracker);
   AppendQuads(
-      quad_list, shared_state_list, root_layer.get(), it, occlusion_tracker);
+      &quad_list, shared_state_list, root_layer.get(), it, occlusion_tracker);
   EXPECT_EQ(quad_list.size(), 9u);
   EXPECT_NEAR(
       occlusion_tracker.overdraw_metrics()->pixels_drawn_opaque(), 0, 1);
   EXPECT_NEAR(
       occlusion_tracker.overdraw_metrics()->pixels_drawn_translucent(), 0, 1);
   EXPECT_NEAR(
       occlusion_tracker.overdraw_metrics()->pixels_culled_for_drawing(), 0, 1);
 }
 
 }  // namespace
 }  // namespace cc