Issue 12556002: Always Close the Autofill UI through the same path

Issue 12556002: Always Close the Autofill UI through the same path (Closed)

Created:
7 years, 9 months ago by csharp

Modified:
7 years, 9 months ago

Reviewers:
Ilya Sherman

CC:
chromium-reviews, Raman Kakilate, tfarina, benquan, dhollowa+watch_chromium.org, ahutter, browser-components-watch_chromium.org, dbeam+watch-autofill_chromium.org, sail+watch_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Albert Bodenhamer, Ilya Sherman

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Always Close the Autofill UI through the same path The autofill controller should always handle all hides, to ensure that everything is properly hidden. TBR=isherman@chromium.org BUG=178564, 178504 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186784

Patch Set 1 #

Patch Set 2 : Disable Test On Linux #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+182 lines, -32 lines)			Patch
M	chrome/browser/autofill/autofill_external_delegate_browsertest.cc	View		3 chunks	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/android/autofill/autofill_popup_view_android.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/autofill/autofill_popup_controller.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
A	chrome/browser/ui/autofill/autofill_popup_controller_browsertest.cc	View	1	1 chunk	+116 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/autofill/autofill_popup_controller_impl.h	View		3 chunks	+2 lines, -6 lines	0 comments	Download
M	chrome/browser/ui/autofill/autofill_popup_controller_impl.cc	View		3 chunks	+2 lines, -11 lines	0 comments	Download
M	chrome/browser/ui/autofill/autofill_popup_controller_unittest.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/autofill/autofill_popup_view.h	View		2 chunks	+11 lines, -2 lines	0 comments	Download
A	chrome/browser/ui/autofill/autofill_popup_view.cc	View		1 chunk	+15 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/cocoa/autofill/autofill_popup_view_bridge.mm	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/gtk/autofill/autofill_popup_view_gtk.cc	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/autofill/autofill_popup_view_views.cc	View		3 chunks	+15 lines, -4 lines	0 comments	Download
M	chrome/chrome_browser_ui.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

csharp

I'm going to disable the test on Linux and submit the rest of the patch. ...

7 years, 9 months ago (2013-03-07 15:24:27 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/csharp@chromium.org/12556002/10001

7 years, 9 months ago (2013-03-07 15:30:58 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/csharp@chromium.org/12556002/15002

7 years, 9 months ago (2013-03-07 16:25:26 UTC) #3

Message was sent while issue was closed.

LGTM

Expand Messages | Collapse Messages