Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8067)

Unified Diff: chrome/browser/ui/android/autofill/autofill_popup_view_android.cc

Issue 12556002: Always Close the Autofill UI through the same path (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Disable Test On Linux Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/android/autofill/autofill_popup_view_android.cc
diff --git a/chrome/browser/ui/android/autofill/autofill_popup_view_android.cc b/chrome/browser/ui/android/autofill/autofill_popup_view_android.cc
index 69b2a4c31e4ef92c59de963200f96d256388c780..4faf5639c763e7e98787d0c8a39feb56c9f8db95 100644
--- a/chrome/browser/ui/android/autofill/autofill_popup_view_android.cc
+++ b/chrome/browser/ui/android/autofill/autofill_popup_view_android.cc
@@ -19,9 +19,7 @@ AutofillPopupViewAndroid::AutofillPopupViewAndroid(
AutofillPopupController* controller)
: controller_(controller) {}
-AutofillPopupViewAndroid::~AutofillPopupViewAndroid() {
- controller_->ViewDestroyed();
-}
+AutofillPopupViewAndroid::~AutofillPopupViewAndroid() {}
void AutofillPopupViewAndroid::Show() {
JNIEnv* env = base::android::AttachCurrentThread();
@@ -37,6 +35,8 @@ void AutofillPopupViewAndroid::Show() {
}
void AutofillPopupViewAndroid::Hide() {
+ AutofillPopupView::Hide();
+
JNIEnv* env = base::android::AttachCurrentThread();
Java_AutofillPopupGlue_dismiss(env, java_object_.obj());
}

Powered by Google App Engine
This is Rietveld 408576698