Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5831)

Unified Diff: chrome/browser/ui/autofill/autofill_popup_view.h

Issue 12556002: Always Close the Autofill UI through the same path (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Disable Test On Linux Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/autofill/autofill_popup_view.h
diff --git a/chrome/browser/ui/autofill/autofill_popup_view.h b/chrome/browser/ui/autofill/autofill_popup_view.h
index 73198fd48941c582a7b1f713b04a0ea99da4bec5..531b0a85576477880078774f999af45367216762 100644
--- a/chrome/browser/ui/autofill/autofill_popup_view.h
+++ b/chrome/browser/ui/autofill/autofill_popup_view.h
@@ -46,7 +46,9 @@ class AutofillPopupView {
virtual void Show() = 0;
// Hides the popup from view. This will cause the popup to be deleted.
- virtual void Hide() = 0;
+ // TODO(csharp): Make Hide a pure virtual function again, once hide_call_ is
+ // removed.
+ virtual void Hide();
// Invalidates the given row and redraw it.
virtual void InvalidateRow(size_t row) = 0;
@@ -58,7 +60,14 @@ class AutofillPopupView {
static AutofillPopupView* Create(AutofillPopupController* controller);
protected:
- virtual ~AutofillPopupView() {}
+ AutofillPopupView();
+ virtual ~AutofillPopupView();
+
+ private:
+ // Used to check that the hide function was called, to check that the class
+ // is only destroyed through the Hide function. Remove after Dev channel
+ // release.
+ bool hide_called_;
};
#endif // CHROME_BROWSER_UI_AUTOFILL_AUTOFILL_POPUP_VIEW_H_
« no previous file with comments | « chrome/browser/ui/autofill/autofill_popup_controller_unittest.cc ('k') | chrome/browser/ui/autofill/autofill_popup_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698