Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2013)

Unified Diff: chrome/browser/ui/autofill/autofill_popup_controller_impl.h

Issue 12556002: Always Close the Autofill UI through the same path (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Disable Test On Linux Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/autofill/autofill_popup_controller_impl.h
diff --git a/chrome/browser/ui/autofill/autofill_popup_controller_impl.h b/chrome/browser/ui/autofill/autofill_popup_controller_impl.h
index cd0f957ef3792a702d12cf2df19e0ffbc57dc290..ca819b6d543c4055d98f5ff7340a830c856f694d 100644
--- a/chrome/browser/ui/autofill/autofill_popup_controller_impl.h
+++ b/chrome/browser/ui/autofill/autofill_popup_controller_impl.h
@@ -47,8 +47,8 @@ class AutofillPopupControllerImpl : public AutofillPopupController,
const std::vector<int>& identifiers);
// Hides the popup and destroys the controller. This also invalidates
- // |delegate_|. Virtual for testing.
- virtual void Hide();
+ // |delegate_|.
+ virtual void Hide() OVERRIDE;
// KeyboardListener implementation.
virtual bool HandleKeyPressEvent(
@@ -64,7 +64,6 @@ class AutofillPopupControllerImpl : public AutofillPopupController,
virtual ~AutofillPopupControllerImpl();
// AutofillPopupController implementation.
- virtual void ViewDestroyed() OVERRIDE;
virtual void UpdateBoundsAndRedrawPopup() OVERRIDE;
virtual void MouseHovered(int x, int y) OVERRIDE;
virtual void MouseClicked(int x, int y) OVERRIDE;
@@ -195,9 +194,6 @@ class AutofillPopupControllerImpl : public AutofillPopupController,
// |kNoSelection| indicates that no line is currently selected.
int selected_line_;
- // True if |HideInternal| has already been called.
- bool is_hiding_;
-
base::WeakPtrFactory<AutofillPopupControllerImpl> weak_ptr_factory_;
};

Powered by Google App Engine
This is Rietveld 408576698