Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(881)

Issue 12475002: Delete memory manager dead code. (Closed)

Created:
7 years, 9 months ago by ccameron
Modified:
7 years, 9 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium
Visibility:
Public.

Description

Delete memory manager dead code. There have existed two paths in the memory manager for a few months -- the old path which uniformly distributes all memory across all visible renderers, and the new path which takes into account the needs of each renderer. The transition was made from the old policy to the new policy quite a while ago, so we can safely get rid of the old policy. BUG=150883 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=187678

Patch Set 1 #

Patch Set 2 : Resolve against HEAD #

Patch Set 3 : Resolve against CrOS changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -570 lines) Patch
M chrome/browser/chrome_browser_main.cc View 1 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/login/chrome_restart_request.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/gpu/chrome_gpu_util.h View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/browser/gpu/chrome_gpu_util.cc View 1 1 chunk +0 lines, -61 lines 0 comments Download
M content/browser/gpu/gpu_data_manager_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/gpu/gpu_data_manager_impl.cc View 1 1 chunk +0 lines, -16 lines 0 comments Download
M content/browser/gpu/gpu_process_host.cc View 1 2 chunks +1 line, -5 lines 0 comments Download
M content/common/gpu/gpu_memory_manager.h View 10 chunks +6 lines, -41 lines 0 comments Download
M content/common/gpu/gpu_memory_manager.cc View 1 16 chunks +14 lines, -215 lines 0 comments Download
M content/common/gpu/gpu_memory_manager_unittest.cc View 8 chunks +13 lines, -187 lines 0 comments Download
M content/common/gpu/gpu_memory_uma_stats.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M content/common/gpu/gpu_messages.h View 1 2 chunks +0 lines, -6 lines 0 comments Download
M content/gpu/gpu_child_thread.cc View 1 2 chunks +0 lines, -7 lines 0 comments Download
M content/public/browser/gpu_data_manager.h View 1 chunk +0 lines, -5 lines 0 comments Download
M gpu/command_buffer/service/gpu_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/service/gpu_switches.cc View 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
ccameron
A sort run-down of the changes is: Inside the GpuMemoryManager, this is everything that is ...
7 years, 9 months ago (2013-03-06 21:16:14 UTC) #1
piman
LGTM. Note, you'll need other OWNERS for stuff in chrome/ and for IPCs.
7 years, 9 months ago (2013-03-06 22:07:09 UTC) #2
ccameron
Adding ben for chrome/ review. Adding tsepez for IPC review.
7 years, 9 months ago (2013-03-08 19:28:33 UTC) #3
Tom Sepez
LGTM on deleting code.
7 years, 9 months ago (2013-03-09 00:21:47 UTC) #4
Ben Goodger (Google)
lgtm
7 years, 9 months ago (2013-03-11 16:25:12 UTC) #5
ccameron
Thanks!!
7 years, 9 months ago (2013-03-11 22:53:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ccameron@chromium.org/12475002/10001
7 years, 9 months ago (2013-03-11 22:56:01 UTC) #7
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 9 months ago (2013-03-12 01:37:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ccameron@chromium.org/12475002/28001
7 years, 9 months ago (2013-03-12 17:58:48 UTC) #9
commit-bot: I haz the power
7 years, 9 months ago (2013-03-12 22:57:30 UTC) #10
Message was sent while issue was closed.
Change committed as 187678

Powered by Google App Engine
This is Rietveld 408576698