Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 12315094: Remove kDefaultHostDesktopType from browser_finder.cc. (Closed)

Created:
7 years, 10 months ago by gab
Modified:
7 years, 9 months ago
CC:
chromium-reviews, jennb, tfarina, jianli, kkania, Dmitry Titov, sail+watch_chromium.org, Aaron Boodman, robertshield, dcheng, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Remove kDefaultHostDesktopType from browser_finder.cc. This forces GetBrowserCount() and GetTabbedBrowserCount() to also take HostDesktopType; changed all consumers to provide desktop context in their query. Introducing GetTotalBrowserCountForProfile() which is like GetBrowserCount(), but cummulative over all desktops; used in two scenarios where the caller of the old GetBrowserCount() actually wanted to know whether all browsers for a given profile were gone from the p.o.v. of the browser process (i.e. accross all desktops). BUG=129187 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=185092

Patch Set 1 : #

Patch Set 2 : fix ChromeMainTest.SecondLaunchFromIncognitoWithNormalUrl #

Patch Set 3 : fix StartupBrowserCreatorTest.ProfilesWithoutPagesNotLaunched #

Unified diffs Side-by-side diffs Delta from patch set Stats (+153 lines, -82 lines) Patch
M chrome/browser/app_controller_mac.mm View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/automation/testing_automation_provider.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chrome_main_browsertest.cc View 1 5 chunks +13 lines, -7 lines 0 comments Download
M chrome/browser/extensions/api/management/management_apitest.cc View 6 chunks +16 lines, -8 lines 0 comments Download
M chrome/browser/extensions/app_process_apitest.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/extensions/window_open_apitest.cc View 3 chunks +8 lines, -3 lines 0 comments Download
M chrome/browser/popup_blocker_browsertest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_browsertest.cc View 8 chunks +18 lines, -9 lines 0 comments Download
M chrome/browser/ui/browser_finder.h View 1 chunk +10 lines, -4 lines 0 comments Download
M chrome/browser/ui/browser_finder.cc View 2 chunks +13 lines, -12 lines 0 comments Download
M chrome/browser/ui/panels/panel_browsertest.cc View 4 chunks +12 lines, -4 lines 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator_browsertest.cc View 1 2 15 chunks +27 lines, -14 lines 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator_interactive_uitest.cc View 1 chunk +12 lines, -8 lines 0 comments Download
M chrome/browser/ui/views/frame/app_non_client_frame_view_ash_browsertest.cc View 3 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
gab
Ben, please take a look, feel free to CQ. Thanks! Gab
7 years, 10 months ago (2013-02-25 23:26:16 UTC) #1
gab
Ben, friendly ping, fixed ChromeMainTest.SecondLaunchFromIncognitoWithNormalUrl if you skipped reviewing this because of it failing. Cheers! ...
7 years, 10 months ago (2013-02-27 00:03:01 UTC) #2
Ben Goodger (Google)
lgtm
7 years, 9 months ago (2013-02-27 18:26:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gab@chromium.org/12315094/5001
7 years, 9 months ago (2013-02-27 18:31:42 UTC) #4
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=14536
7 years, 9 months ago (2013-02-27 21:16:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gab@chromium.org/12315094/6019
7 years, 9 months ago (2013-02-27 21:39:01 UTC) #6
commit-bot: I haz the power
7 years, 9 months ago (2013-02-28 01:17:43 UTC) #7
Message was sent while issue was closed.
Change committed as 185092

Powered by Google App Engine
This is Rietveld 408576698