Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Unified Diff: chrome/browser/ui/panels/panel_browsertest.cc

Issue 12315094: Remove kDefaultHostDesktopType from browser_finder.cc. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix StartupBrowserCreatorTest.ProfilesWithoutPagesNotLaunched Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/browser_finder.cc ('k') | chrome/browser/ui/startup/startup_browser_creator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/panels/panel_browsertest.cc
diff --git a/chrome/browser/ui/panels/panel_browsertest.cc b/chrome/browser/ui/panels/panel_browsertest.cc
index 63547e798e1038e9195fcbf1481514abe6240a30..dbc2235ee689637a7480926862d93b5c7f3538ee 100644
--- a/chrome/browser/ui/panels/panel_browsertest.cc
+++ b/chrome/browser/ui/panels/panel_browsertest.cc
@@ -1701,7 +1701,9 @@ IN_PROC_BROWSER_TEST_F(PanelBrowserTest, DevTools) {
// Open devtools.
size_t num_browsers = 1;
- EXPECT_EQ(num_browsers, chrome::GetBrowserCount(browser()->profile()));
+ EXPECT_EQ(num_browsers, chrome::GetBrowserCount(
+ browser()->profile(),
+ browser()->host_desktop_type()));
content::WindowedNotificationObserver signal(
chrome::NOTIFICATION_BROWSER_WINDOW_READY,
content::NotificationService::AllSources());
@@ -1710,7 +1712,9 @@ IN_PROC_BROWSER_TEST_F(PanelBrowserTest, DevTools) {
// Check that the new browser window that opened is dev tools window.
++num_browsers;
- EXPECT_EQ(num_browsers, chrome::GetBrowserCount(browser()->profile()));
+ EXPECT_EQ(num_browsers, chrome::GetBrowserCount(
+ browser()->profile(),
+ browser()->host_desktop_type()));
for (chrome::BrowserIterator iter; !iter.done(); iter.Next()) {
if (*iter == browser())
continue;
@@ -1737,7 +1741,9 @@ IN_PROC_BROWSER_TEST_F(PanelBrowserTest, DevToolsConsole) {
// Open devtools console.
size_t num_browsers = 1;
- EXPECT_EQ(num_browsers, chrome::GetBrowserCount(browser()->profile()));
+ EXPECT_EQ(num_browsers, chrome::GetBrowserCount(
+ browser()->profile(),
+ browser()->host_desktop_type()));
content::WindowedNotificationObserver signal(
chrome::NOTIFICATION_BROWSER_WINDOW_READY,
content::NotificationService::AllSources());
@@ -1746,7 +1752,9 @@ IN_PROC_BROWSER_TEST_F(PanelBrowserTest, DevToolsConsole) {
// Check that the new browser window that opened is dev tools window.
++num_browsers;
- EXPECT_EQ(num_browsers, chrome::GetBrowserCount(browser()->profile()));
+ EXPECT_EQ(num_browsers, chrome::GetBrowserCount(
+ browser()->profile(),
+ browser()->host_desktop_type()));
for (chrome::BrowserIterator iter; !iter.done(); iter.Next()) {
if (*iter == browser())
continue;
« no previous file with comments | « chrome/browser/ui/browser_finder.cc ('k') | chrome/browser/ui/startup/startup_browser_creator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698