Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3322)

Unified Diff: chrome/browser/ui/browser_browsertest.cc

Issue 12315094: Remove kDefaultHostDesktopType from browser_finder.cc. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix StartupBrowserCreatorTest.ProfilesWithoutPagesNotLaunched Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/browser.cc ('k') | chrome/browser/ui/browser_finder.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/browser_browsertest.cc
diff --git a/chrome/browser/ui/browser_browsertest.cc b/chrome/browser/ui/browser_browsertest.cc
index a367044e4683adc259f73cd3771afae744c8bbf9..38937ad5e0b38283e27e04bdf0f1feafd2395d47 100644
--- a/chrome/browser/ui/browser_browsertest.cc
+++ b/chrome/browser/ui/browser_browsertest.cc
@@ -789,7 +789,8 @@ IN_PROC_BROWSER_TEST_F(BrowserTest, DISABLED_ConvertTabToAppShortcut) {
WebContents* app_tab = chrome::AddSelectedTabWithURL(
browser(), http_url, content::PAGE_TRANSITION_TYPED);
ASSERT_EQ(2, browser()->tab_strip_model()->count());
- ASSERT_EQ(1u, chrome::GetBrowserCount(browser()->profile()));
+ ASSERT_EQ(1u, chrome::GetBrowserCount(browser()->profile(),
+ browser()->host_desktop_type()));
// Normal tabs should accept load drops.
EXPECT_TRUE(initial_tab->GetMutableRendererPrefs()->can_accept_load_drops);
@@ -799,7 +800,8 @@ IN_PROC_BROWSER_TEST_F(BrowserTest, DISABLED_ConvertTabToAppShortcut) {
chrome::ConvertTabToAppWindow(browser(), app_tab);
// The launch should have created a new browser.
- ASSERT_EQ(2u, chrome::GetBrowserCount(browser()->profile()));
+ ASSERT_EQ(2u, chrome::GetBrowserCount(browser()->profile(),
+ browser()->host_desktop_type()));
// Find the new browser.
Browser* app_browser = NULL;
@@ -934,7 +936,8 @@ IN_PROC_BROWSER_TEST_F(BrowserTest, AppIdSwitch) {
// Check that the new browser has an app name.
// The launch should have created a new browser.
- ASSERT_EQ(2u, chrome::GetBrowserCount(browser()->profile()));
+ ASSERT_EQ(2u, chrome::GetBrowserCount(browser()->profile(),
+ browser()->host_desktop_type()));
// Find the new browser.
Browser* new_browser = NULL;
@@ -1041,7 +1044,8 @@ IN_PROC_BROWSER_TEST_F(BrowserTest, RestorePinnedTabs) {
launch.ProcessStartupURLs(std::vector<GURL>());
// The launch should have created a new browser.
- ASSERT_EQ(2u, chrome::GetBrowserCount(browser()->profile()));
+ ASSERT_EQ(2u, chrome::GetBrowserCount(browser()->profile(),
+ browser()->host_desktop_type()));
// Find the new browser.
Browser* new_browser = NULL;
@@ -1115,7 +1119,8 @@ IN_PROC_BROWSER_TEST_F(BrowserTest, OpenAppWindowLikeNtp) {
EXPECT_EQ(extension_app->GetFullLaunchURL(), app_window->GetURL());
// The launch should have created a new browser.
- ASSERT_EQ(2u, chrome::GetBrowserCount(browser()->profile()));
+ ASSERT_EQ(2u, chrome::GetBrowserCount(browser()->profile(),
+ browser()->host_desktop_type()));
// Find the new browser.
Browser* new_browser = NULL;
@@ -1862,7 +1867,8 @@ class ClickModifierTest : public InProcessBrowserTest {
WebKit::WebMouseEvent::Button button,
WindowOpenDisposition disposition) {
ui_test_utils::NavigateToURL(browser, url);
- EXPECT_EQ(1u, chrome::GetBrowserCount(browser->profile()));
+ EXPECT_EQ(1u, chrome::GetBrowserCount(browser->profile(),
+ browser->host_desktop_type()));
EXPECT_EQ(1, browser->tab_strip_model()->count());
content::WebContents* web_contents =
browser->tab_strip_model()->GetActiveWebContents();
@@ -1882,7 +1888,8 @@ class ClickModifierTest : public InProcessBrowserTest {
same_tab_observer.WaitForObservation(
base::Bind(&content::RunThisRunLoop, base::Unretained(&run_loop)),
content::GetQuitTaskForRunLoop(&run_loop));
- EXPECT_EQ(1u, chrome::GetBrowserCount(browser->profile()));
+ EXPECT_EQ(1u, chrome::GetBrowserCount(browser->profile(),
+ browser->host_desktop_type()));
EXPECT_EQ(1, browser->tab_strip_model()->count());
EXPECT_EQ(getSecondPageTitle(), web_contents->GetTitle());
return;
@@ -1895,11 +1902,13 @@ class ClickModifierTest : public InProcessBrowserTest {
observer.Wait();
if (disposition == NEW_WINDOW) {
- EXPECT_EQ(2u, chrome::GetBrowserCount(browser->profile()));
+ EXPECT_EQ(2u, chrome::GetBrowserCount(browser->profile(),
+ browser->host_desktop_type()));
return;
}
- EXPECT_EQ(1u, chrome::GetBrowserCount(browser->profile()));
+ EXPECT_EQ(1u, chrome::GetBrowserCount(browser->profile(),
+ browser->host_desktop_type()));
EXPECT_EQ(2, browser->tab_strip_model()->count());
web_contents = browser->tab_strip_model()->GetActiveWebContents();
WaitForLoadStop(web_contents);
« no previous file with comments | « chrome/browser/ui/browser.cc ('k') | chrome/browser/ui/browser_finder.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698