Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 1216403003: [Feedback] Move all tests to chrome/javatests (Closed)

Created:
5 years, 5 months ago by nyquist
Modified:
5 years, 5 months ago
Reviewers:
newt (away)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@use-connectivity-task-callback
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Feedback] Move all tests to chrome/javatests This CL moves the tests to a place not dependent on the Chrome shell. Also, it updates the ConnectivityCheckerTestBase to instead just depend on NativeLibraryTestBase, since it doesn't need anything else. The FeedbackCollectorTest needs an activity, and as such it now uses ChromeActivity and the ChromeActivityTestCaseBase. The profile is retrieved from the last used one instead of from the current tab. BUG=386395 Committed: https://crrev.com/95a2fd94e570e83a9d111d34e3c92df2e247281f Cr-Commit-Position: refs/heads/master@{#337148}

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : Rebased #

Patch Set 4 : Add missing @VisibleForTesting annotations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -898 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/feedback/FeedbackCollector.java View 1 2 3 4 chunks +4 lines, -0 lines 0 comments Download
A + chrome/android/javatests/src/org/chromium/chrome/browser/feedback/ConnectivityCheckerTest.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/android/javatests/src/org/chromium/chrome/browser/feedback/ConnectivityCheckerTestBase.java View 4 chunks +3 lines, -5 lines 0 comments Download
A + chrome/android/javatests/src/org/chromium/chrome/browser/feedback/ConnectivityTaskTest.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/android/javatests/src/org/chromium/chrome/browser/feedback/FeedbackCollectorTest.java View 1 3 chunks +15 lines, -9 lines 0 comments Download
D chrome/android/javatests_shell/src/org/chromium/chrome/browser/feedback/ConnectivityCheckerTest.java View 1 chunk +0 lines, -135 lines 0 comments Download
D chrome/android/javatests_shell/src/org/chromium/chrome/browser/feedback/ConnectivityCheckerTestBase.java View 1 chunk +0 lines, -193 lines 0 comments Download
D chrome/android/javatests_shell/src/org/chromium/chrome/browser/feedback/ConnectivityTaskTest.java View 1 1 chunk +0 lines, -214 lines 0 comments Download
D chrome/android/javatests_shell/src/org/chromium/chrome/browser/feedback/FeedbackCollectorTest.java View 1 1 chunk +0 lines, -344 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 13 (6 generated)
nyquist
newt: PTAL
5 years, 5 months ago (2015-07-01 18:07:10 UTC) #2
newt (away)
lgtm
5 years, 5 months ago (2015-07-01 18:13:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1216403003/40001
5 years, 5 months ago (2015-07-01 23:06:37 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/40225)
5 years, 5 months ago (2015-07-01 23:38:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1216403003/60001
5 years, 5 months ago (2015-07-02 00:04:03 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 5 months ago (2015-07-02 00:43:09 UTC) #12
commit-bot: I haz the power
5 years, 5 months ago (2015-07-02 00:44:26 UTC) #13
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/95a2fd94e570e83a9d111d34e3c92df2e247281f
Cr-Commit-Position: refs/heads/master@{#337148}

Powered by Google App Engine
This is Rietveld 408576698