Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3336)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/feedback/FeedbackCollector.java

Issue 1216403003: [Feedback] Move all tests to chrome/javatests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@use-connectivity-task-callback
Patch Set: Add missing @VisibleForTesting annotations Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/javatests/src/org/chromium/chrome/browser/feedback/ConnectivityCheckerTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/feedback/FeedbackCollector.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/feedback/FeedbackCollector.java b/chrome/android/java/src/org/chromium/chrome/browser/feedback/FeedbackCollector.java
index a8a87abff6672827c28793c1b88309856c2aac8c..c37c2d9b1bed01ee93520b66524fe736fbb4818e 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/feedback/FeedbackCollector.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/feedback/FeedbackCollector.java
@@ -209,6 +209,7 @@ public class FeedbackCollector
/**
* @return the default description to invoke feedback with.
*/
+ @VisibleForTesting
public String getDescription() {
ThreadUtils.assertOnUiThread();
return mDescription;
@@ -218,6 +219,7 @@ public class FeedbackCollector
* Sets the screenshot to use for the feedback report.
* @param screenshot the user visible screenshot.
*/
+ @VisibleForTesting
public void setScreenshot(Bitmap screenshot) {
ThreadUtils.assertOnUiThread();
mScreenshot = screenshot;
@@ -226,6 +228,7 @@ public class FeedbackCollector
/**
* @return the screenshot to use for the feedback report.
*/
+ @VisibleForTesting
public Bitmap getScreenshot() {
ThreadUtils.assertOnUiThread();
return mScreenshot;
@@ -234,6 +237,7 @@ public class FeedbackCollector
/**
* @return the collected data as a {@link Bundle}.
*/
+ @VisibleForTesting
public Bundle getBundle() {
ThreadUtils.assertOnUiThread();
addUrl();
« no previous file with comments | « no previous file | chrome/android/javatests/src/org/chromium/chrome/browser/feedback/ConnectivityCheckerTest.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698