Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 1220053004: [Feedback] Add connection type data to feedback reports. (Closed)

Created:
5 years, 5 months ago by nyquist
Modified:
5 years, 5 months ago
Reviewers:
gone
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@change-test-types-for-feedback
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Feedback] Add connection type data to feedback reports. Currently a connection check is performed for feedback reports. This CL also adds information about the current connection to the report. The reported data fields are the connection type and the bandwidth, given in Mbps. BUG=386395 Committed: https://crrev.com/b8827395a72e786259c24806fcc0f5827e2a88c5 Cr-Commit-Position: refs/heads/master@{#337154}

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -13 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/feedback/ConnectivityTask.java View 9 chunks +58 lines, -8 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/feedback/ConnectivityTaskTest.java View 1 4 chunks +10 lines, -4 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/feedback/FeedbackCollectorTest.java View 1 2 chunks +3 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (3 generated)
nyquist
dfalcantara: PTAL
5 years, 5 months ago (2015-07-01 18:24:07 UTC) #2
gone
lgtm
5 years, 5 months ago (2015-07-01 22:34:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1220053004/20001
5 years, 5 months ago (2015-07-02 00:54:21 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-02 01:30:55 UTC) #7
commit-bot: I haz the power
5 years, 5 months ago (2015-07-02 01:31:55 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b8827395a72e786259c24806fcc0f5827e2a88c5
Cr-Commit-Position: refs/heads/master@{#337154}

Powered by Google App Engine
This is Rietveld 408576698