Description[Feedback] Use callbacks for FeedbackCollector and use ScreenshotTask
This CL adds support for using callbacks with the FeedbackCollector.
The FeedbackCollector now always waits for the screenshot, and waits up
to 500 ms for connectivity checks to finish. If taking the screenshot
takes a long time, the connectivity checks get more time to finish.
The callback for the FeedbackCollector is called when both these
statements are true:
- Screenshot is finished.
- Connectivity checks are finished or timeout has expired.
Additional required steps part of this CL:
- Start gathering screenshots using the ScreenshotTask.
- Update all callers of HelpAndFeedback and the FeedbackCollector.
BUG=386395
Committed: https://crrev.com/a79fb716f855029ab0f35eb11b666b3bed80fb3d
Cr-Commit-Position: refs/heads/master@{#337131}
Patch Set 1 #Patch Set 2 : Rebased #Patch Set 3 : Merged in parent branch and changed CONNECTIVITY_CHECK_TIMEOUT_MS back to 5000 #Patch Set 4 : Squashed branch #Depends on Patchset: Dependent Patchsets: Messages
Total messages: 21 (10 generated)
|