Merged all Chromoting Host code into remoting_core.dll (Windows).

Merged all Chromoting Host code into remoting_core.dll (Windows).

Consolidated all installable Chromoting Host core into remoting_core.dll and converted all executables into thin wrappers around entry points exposed by remoting_core.dll. This reduces size of the installer by approximately 600KB.

BUG=170200
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=179226

[alexeypa (please no reviews), 2013-01-17 19:03:03]

PTAL.

[Wez, 2013-01-17 19:04:40]

On 2013/01/17 19:03:03, alexeypa wrote:
> PTAL.

nit: Please clarify in the description that the 600KB is from the _installer_,
i.e. the installed footprint is reduce even further. :D

[Sergey Ulanov, 2013-01-18 21:14:54]

https://codereview.chromium.org/11970044/diff/2002/remoting/branding_Chrome
File remoting/branding_Chrome (right):

https://codereview.chromium.org/11970044/diff/2002/remoting/branding_Chrome#n...
remoting/branding_Chrome:12: CORE_DESCRIPTION=Chrome Remote Desktop Core
Maybe "Chrome Remote Desktop Host Core"?

https://codereview.chromium.org/11970044/diff/2002/remoting/branding_Chromium
File remoting/branding_Chromium (right):

https://codereview.chromium.org/11970044/diff/2002/remoting/branding_Chromium...
remoting/branding_Chromium:12: CORE_DESCRIPTION=Chromoting Core
Chromoting Host Core?

https://codereview.chromium.org/11970044/diff/2002/remoting/host/desktop_proc...
File remoting/host/desktop_process_entry.h (right):

https://codereview.chromium.org/11970044/diff/2002/remoting/host/desktop_proc...
remoting/host/desktop_process_entry.h:13: HOST_EXPORT int RunDesktopProcess(int
argc, char** argv);
Maybe call it DesktopProcessMain()?

https://codereview.chromium.org/11970044/diff/2002/remoting/host/win/daemon_p...
File remoting/host/win/daemon_process_main.cc (right):

https://codereview.chromium.org/11970044/diff/2002/remoting/host/win/daemon_p...
remoting/host/win/daemon_process_main.cc:11: void DaemonProcessMain() {
why not main()?

https://codereview.chromium.org/11970044/diff/2002/remoting/remoting.gyp
File remoting/remoting.gyp (right):

https://codereview.chromium.org/11970044/diff/2002/remoting/remoting.gyp#newc...
remoting/remoting.gyp:1280: 'EntryPointSymbol': 'ElevatedControllerMain',
Do we need this? can we use main() instead? On mac and linux we may want to have
core in static library too, but it won't be possible to specify entry point name
there.

[alexeypa (please no reviews), 2013-01-18 22:06:10]

https://codereview.chromium.org/11970044/diff/2002/remoting/branding_Chrome
File remoting/branding_Chrome (right):

https://codereview.chromium.org/11970044/diff/2002/remoting/branding_Chrome#n...
remoting/branding_Chrome:12: CORE_DESCRIPTION=Chrome Remote Desktop Core
On 2013/01/18 21:14:55, sergeyu wrote:
> Maybe "Chrome Remote Desktop Host Core"?

While writing the multi-process specification I encountered the problem that we
call two different thigh "Chromoting Host":
1. The whole me2me host that includes everything that gets installed on the host
machine, except the webapp.
2. The host code handling incoming connections, capturing screen, etc.

It becomes very confusing so I'm trying to avoid using "host" for anything that
is not #2 from above.

Now, I realize that remoting_core.dll will have all host's code. But it will
also have other code, co by the argument above it is again desirable to avoid
calling it "host".

https://codereview.chromium.org/11970044/diff/2002/remoting/branding_Chromium
File remoting/branding_Chromium (right):

https://codereview.chromium.org/11970044/diff/2002/remoting/branding_Chromium...
remoting/branding_Chromium:12: CORE_DESCRIPTION=Chromoting Core
On 2013/01/18 21:14:55, sergeyu wrote:
> Chromoting Host Core?

See my other comment.

https://codereview.chromium.org/11970044/diff/2002/remoting/host/desktop_proc...
File remoting/host/desktop_process_entry.h (right):

https://codereview.chromium.org/11970044/diff/2002/remoting/host/desktop_proc...
remoting/host/desktop_process_entry.h:13: HOST_EXPORT int RunDesktopProcess(int
argc, char** argv);
On 2013/01/18 21:14:55, sergeyu wrote:
> Maybe call it DesktopProcessMain()?

There is already DesktopProcessMain() in
remoting/host/win/desktop_process_main.cc. The logic here is that RunXxx is
exported from remoting_core.dll. XxxMain is specified as an entry point in the
EXE wrapper.

https://codereview.chromium.org/11970044/diff/2002/remoting/host/win/daemon_p...
File remoting/host/win/daemon_process_main.cc (right):

https://codereview.chromium.org/11970044/diff/2002/remoting/host/win/daemon_p...
remoting/host/win/daemon_process_main.cc:11: void DaemonProcessMain() {
On 2013/01/18 21:14:55, sergeyu wrote:
> why not main()?

main() implies that CRT is here and initialized.

https://codereview.chromium.org/11970044/diff/2002/remoting/remoting.gyp
File remoting/remoting.gyp (right):

https://codereview.chromium.org/11970044/diff/2002/remoting/remoting.gyp#newc...
remoting/remoting.gyp:1280: 'EntryPointSymbol': 'ElevatedControllerMain',
On 2013/01/18 21:14:55, sergeyu wrote:
> Do we need this? can we use main() instead? On mac and linux we may want to
have
> core in static library too, but it won't be possible to specify entry point
name
> there.

Getting rid of CRT saves us about 116KB. Technically we could remove CRT and use
main() as the entry point. The only problem is, again, that main() implies that
there is CRT. So bugs can creep in.

[alexeypa (please no reviews), 2013-01-24 19:49:57]

ping

[Sergey Ulanov, 2013-01-24 20:02:10]

LGTM, but see my suggestions about naming.
Sorry for delay.

https://chromiumcodereview.appspot.com/11970044/diff/2002/remoting/branding_C...
File remoting/branding_Chrome (right):

https://chromiumcodereview.appspot.com/11970044/diff/2002/remoting/branding_C...
remoting/branding_Chrome:12: CORE_DESCRIPTION=Chrome Remote Desktop Core
On 2013/01/18 22:06:10, alexeypa wrote:
> On 2013/01/18 21:14:55, sergeyu wrote:
> > Maybe "Chrome Remote Desktop Host Core"?
> 
> While writing the multi-process specification I encountered the problem that
we
> call two different thigh "Chromoting Host":
> 1. The whole me2me host that includes everything that gets installed on the
host
> machine, except the webapp.
> 2. The host code handling incoming connections, capturing screen, etc.
> 
> It becomes very confusing so I'm trying to avoid using "host" for anything
that
> is not #2 from above.
> 
> Now, I realize that remoting_core.dll will have all host's code. But it will
> also have other code, co by the argument above it is again desirable to avoid
> calling it "host".

Well, we still need some name for (1). Maybe call it "Chrome Remote Desktop Host
Service Core"?

https://chromiumcodereview.appspot.com/11970044/diff/2002/remoting/host/deskt...
File remoting/host/desktop_process_entry.h (right):

https://chromiumcodereview.appspot.com/11970044/diff/2002/remoting/host/deskt...
remoting/host/desktop_process_entry.h:13: HOST_EXPORT int RunDesktopProcess(int
argc, char** argv);
On 2013/01/18 22:06:10, alexeypa wrote:
> On 2013/01/18 21:14:55, sergeyu wrote:
> > Maybe call it DesktopProcessMain()?
> 
> There is already DesktopProcessMain() in
> remoting/host/win/desktop_process_main.cc. The logic here is that RunXxx is
> exported from remoting_core.dll. XxxMain is specified as an entry point in the
> EXE wrapper.

I suggest that you rename DaemonProcessMain() to DaemonProcessEntryPoint(), and
call this DesktopProcessMain(). Also note that they are in different namespaces
so they could have the same name (but I'm not suggesting doing it).

https://chromiumcodereview.appspot.com/11970044/diff/2002/remoting/host/win/d...
File remoting/host/win/daemon_process_main.cc (right):

https://chromiumcodereview.appspot.com/11970044/diff/2002/remoting/host/win/d...
remoting/host/win/daemon_process_main.cc:11: void DaemonProcessMain() {
On 2013/01/18 22:06:10, alexeypa wrote:
> On 2013/01/18 21:14:55, sergeyu wrote:
> > why not main()?
> 
> main() implies that CRT is here and initialized.

Ok, I see now. Maybe then call it DaemonProcessEntryPoint() to make it less
confusing? It's just looks strange that it's called Main(), yet, doesn't have
argv/argc

[alexeypa (please no reviews), 2013-01-28 21:57:29]

https://chromiumcodereview.appspot.com/11970044/diff/2002/remoting/branding_C...
File remoting/branding_Chrome (right):

https://chromiumcodereview.appspot.com/11970044/diff/2002/remoting/branding_C...
remoting/branding_Chrome:12: CORE_DESCRIPTION=Chrome Remote Desktop Core
On 2013/01/24 20:02:11, sergeyu wrote:
> Well, we still need some name for (1). Maybe call it "Chrome Remote Desktop
Host
> Service Core"?

"Core" is not (1). remoting_core.dll is just a container for code of other
components. It does not have a role of it's own, so I don't think naming it by
its role is going to work. "Core" is generic and meaning-less enough that it
might work. It could be just "remoting.dll" as well.

https://chromiumcodereview.appspot.com/11970044/diff/2002/remoting/host/deskt...
File remoting/host/desktop_process_entry.h (right):

https://chromiumcodereview.appspot.com/11970044/diff/2002/remoting/host/deskt...
remoting/host/desktop_process_entry.h:13: HOST_EXPORT int RunDesktopProcess(int
argc, char** argv);
On 2013/01/24 20:02:11, sergeyu wrote:
> On 2013/01/18 22:06:10, alexeypa wrote:
> > On 2013/01/18 21:14:55, sergeyu wrote:
> > > Maybe call it DesktopProcessMain()?
> > 
> > There is already DesktopProcessMain() in
> > remoting/host/win/desktop_process_main.cc. The logic here is that RunXxx is
> > exported from remoting_core.dll. XxxMain is specified as an entry point in
the
> > EXE wrapper.
> 
> I suggest that you rename DaemonProcessMain() to DaemonProcessEntryPoint(),
and
> call this DesktopProcessMain(). Also note that they are in different
namespaces
> so they could have the same name (but I'm not suggesting doing it).

Done.

https://chromiumcodereview.appspot.com/11970044/diff/2002/remoting/host/win/d...
File remoting/host/win/daemon_process_main.cc (right):

https://chromiumcodereview.appspot.com/11970044/diff/2002/remoting/host/win/d...
remoting/host/win/daemon_process_main.cc:11: void DaemonProcessMain() {
On 2013/01/24 20:02:11, sergeyu wrote:
> On 2013/01/18 22:06:10, alexeypa wrote:
> > On 2013/01/18 21:14:55, sergeyu wrote:
> > > why not main()?
> > 
> > main() implies that CRT is here and initialized.
> 
> Ok, I see now. Maybe then call it DaemonProcessEntryPoint() to make it less
> confusing? It's just looks strange that it's called Main(), yet, doesn't have
> argv/argc

Done.

[commit-bot: I haz the power, 2013-01-28 21:58:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alexeypa@chromium.org/11970044/19001

[commit-bot: I haz the power, 2013-01-29 00:42:27]

Change committed as 179226