remoting/host/win/daemon_process_main.cc - Issue 11970044: Merged all Chromoting Host code into remoting_core.dll (Windows).

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: remoting/host/win/daemon_process_main.cc

Issue 11970044: Merged all Chromoting Host code into remoting_core.dll (Windows). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: host_ui_resource.h has been deleted. Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include <windows.h>

	6

	7 #include "remoting/host/win/host_service.h"

	8

	9 // The entry point of the daemon process binary. In order to be really small

	10 // the app doesn't link against the CRT.

	11 void DaemonProcessMain() {
	Sergey Ulanov 2013/01/18 21:14:55 why not main()? why not main()? alexeypa (please no reviews) 2013/01/18 22:06:10 main() implies that CRT is here and initialized. Show quoted text On 2013/01/18 21:14:55, sergeyu wrote: > why not main()? main() implies that CRT is here and initialized. Sergey Ulanov 2013/01/24 20:02:11 Ok, I see now. Maybe then call it DaemonProcessEnt Show quoted text On 2013/01/18 22:06:10, alexeypa wrote: > On 2013/01/18 21:14:55, sergeyu wrote: > > why not main()? > > main() implies that CRT is here and initialized. Ok, I see now. Maybe then call it DaemonProcessEntryPoint() to make it less confusing? It's just looks strange that it's called Main(), yet, doesn't have argv/argc alexeypa (please no reviews) 2013/01/28 21:57:29 Done. Show quoted text On 2013/01/24 20:02:11, sergeyu wrote: > On 2013/01/18 22:06:10, alexeypa wrote: > > On 2013/01/18 21:14:55, sergeyu wrote: > > > why not main()? > > > > main() implies that CRT is here and initialized. > > Ok, I see now. Maybe then call it DaemonProcessEntryPoint() to make it less > confusing? It's just looks strange that it's called Main(), yet, doesn't have > argv/argc Done.
	12 int exit_code = remoting::RunDaemonProcess();

	13 ExitProcess(exit_code);

	14 }

OLD	NEW

« remoting/host/desktop_process_entry.h ('K') | « remoting/host/win/core_resource.h ('k') | remoting/host/win/desktop_process_main.cc » ('j') | remoting/remoting.gyp » ('J')