Issue 11821049: Combine DEBUG_BREAK and DEBUG_PREPARE_STEP_IN into one IC stub kind DEBUG_STUB, encoding DEBUG_BREA…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11821049: Combine DEBUG_BREAK and DEBUG_PREPARE_STEP_IN into one IC stub kind DEBUG_STUB, encoding DEBUG_BREA… (Closed)

Created:
7 years, 11 months ago by Toon Verwaest

Modified:
7 years, 11 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Combine DEBUG_BREAK and DEBUG_PREPARE_STEP_IN into one IC stub kind DEBUG_STUB, encoding DEBUG_BREAK and DEBUG_PREPARE_STEP_IN as extra ic state. Committed: https://code.google.com/p/v8/source/detail?r=13352

Patch Set 1 #

Total comments: 1

Patch Set 2 : Addressed comments #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+54 lines, -52 lines)			Patch
M	src/builtins.h	View		1 chunk	+25 lines, -25 lines	0 comments	Download
M	src/debug.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/ic.cc	View	1	8 chunks	+8 lines, -15 lines	0 comments	Download
M	src/liveedit.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/objects.h	View	1	2 chunks	+7 lines, -0 lines	0 comments	Download
M	src/objects.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	src/objects-inl.h	View	1	2 chunks	+7 lines, -3 lines	0 comments	Download
M	src/stub-cache.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/v8globals.h	View		1 chunk	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Yang

LGTM with a suggestion. https://chromiumcodereview.appspot.com/11821049/diff/1/src/liveedit.cc File src/liveedit.cc (right): https://chromiumcodereview.appspot.com/11821049/diff/1/src/liveedit.cc#newcode1667 src/liveedit.cc:1667: pre_top_frame_code->extra_ic_state() == DEBUG_BREAK) { maybe ...

7 years, 11 months ago (2013-01-10 14:06:47 UTC) #2

Addressed comments.

Expand Messages | Collapse Messages