Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Unified Diff: src/ic.cc

Issue 11821049: Combine DEBUG_BREAK and DEBUG_PREPARE_STEP_IN into one IC stub kind DEBUG_STUB, encoding DEBUG_BREA… (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comments Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/debug.cc ('k') | src/liveedit.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ic.cc
diff --git a/src/ic.cc b/src/ic.cc
index 0db9aa56204afe81f556c53e86e90adfe5a9f083..ba68bebd52ccec17b17b70767b374ed84b69d530 100644
--- a/src/ic.cc
+++ b/src/ic.cc
@@ -52,8 +52,7 @@ char IC::TransitionMarkFromState(IC::State state) {
// We never see the debugger states here, because the state is
// computed from the original code - not the patched code. Let
// these cases fall through to the unreachable code below.
- case DEBUG_BREAK: break;
- case DEBUG_PREPARE_STEP_IN: break;
+ case DEBUG_STUB: break;
}
UNREACHABLE();
return 0;
@@ -347,7 +346,7 @@ void IC::Clear(Address address) {
Code* target = GetTargetAtAddress(address);
// Don't clear debug break inline cache as it will remove the break point.
- if (target->ic_state() == DEBUG_BREAK) return;
+ if (target->is_debug_break()) return;
switch (target->kind()) {
case Code::LOAD_IC: return LoadIC::Clear(address, target);
@@ -770,8 +769,7 @@ void CallICBase::UpdateCaches(LookupResult* lookup,
isolate()->stub_cache()->Set(*name, cache_object->map(), *code);
break;
}
- case DEBUG_BREAK:
- case DEBUG_PREPARE_STEP_IN:
+ case DEBUG_STUB:
break;
case POLYMORPHIC:
UNREACHABLE();
@@ -1066,8 +1064,7 @@ void LoadIC::UpdateCaches(LookupResult* lookup,
// GenerateMonomorphicCacheProbe.
isolate()->stub_cache()->Set(*name, receiver->map(), *code);
break;
- case DEBUG_BREAK:
- case DEBUG_PREPARE_STEP_IN:
+ case DEBUG_STUB:
break;
case POLYMORPHIC:
UNREACHABLE();
@@ -1339,8 +1336,7 @@ void KeyedLoadIC::UpdateCaches(LookupResult* lookup,
}
break;
case MEGAMORPHIC:
- case DEBUG_BREAK:
- case DEBUG_PREPARE_STEP_IN:
+ case DEBUG_STUB:
break;
case MONOMORPHIC_PROTOTYPE_FAILURE:
UNREACHABLE();
@@ -1615,8 +1611,7 @@ void StoreIC::UpdateCaches(LookupResult* lookup,
// Update the stub cache.
isolate()->stub_cache()->Set(*name, receiver->map(), *code);
break;
- case DEBUG_BREAK:
- case DEBUG_PREPARE_STEP_IN:
+ case DEBUG_STUB:
break;
case POLYMORPHIC:
UNREACHABLE();
@@ -1667,8 +1662,7 @@ void KeyedIC::GetReceiverMapsForStub(Handle<Code> stub,
case UNINITIALIZED:
case PREMONOMORPHIC:
case MONOMORPHIC_PROTOTYPE_FAILURE:
- case DEBUG_BREAK:
- case DEBUG_PREPARE_STEP_IN:
+ case DEBUG_STUB:
UNREACHABLE();
break;
}
@@ -2114,8 +2108,7 @@ void KeyedStoreIC::UpdateCaches(LookupResult* lookup,
}
break;
case MEGAMORPHIC:
- case DEBUG_BREAK:
- case DEBUG_PREPARE_STEP_IN:
+ case DEBUG_STUB:
break;
case MONOMORPHIC_PROTOTYPE_FAILURE:
UNREACHABLE();
« no previous file with comments | « src/debug.cc ('k') | src/liveedit.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698