Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Side by Side Diff: src/liveedit.cc

Issue 11821049: Combine DEBUG_BREAK and DEBUG_PREPARE_STEP_IN into one IC stub kind DEBUG_STUB, encoding DEBUG_BREA… (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comments Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ic.cc ('k') | src/objects.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1645 matching lines...) Expand 10 before | Expand all | Expand 10 after
1656 StackFrame* top_frame = frames[top_frame_index]; 1656 StackFrame* top_frame = frames[top_frame_index];
1657 StackFrame* bottom_js_frame = frames[bottom_js_frame_index]; 1657 StackFrame* bottom_js_frame = frames[bottom_js_frame_index];
1658 1658
1659 ASSERT(bottom_js_frame->is_java_script()); 1659 ASSERT(bottom_js_frame->is_java_script());
1660 1660
1661 // Check the nature of the top frame. 1661 // Check the nature of the top frame.
1662 Isolate* isolate = Isolate::Current(); 1662 Isolate* isolate = Isolate::Current();
1663 Code* pre_top_frame_code = pre_top_frame->LookupCode(); 1663 Code* pre_top_frame_code = pre_top_frame->LookupCode();
1664 bool frame_has_padding; 1664 bool frame_has_padding;
1665 if (pre_top_frame_code->is_inline_cache_stub() && 1665 if (pre_top_frame_code->is_inline_cache_stub() &&
1666 pre_top_frame_code->ic_state() == DEBUG_BREAK) { 1666 pre_top_frame_code->is_debug_break()) {
1667 // OK, we can drop inline cache calls. 1667 // OK, we can drop inline cache calls.
1668 *mode = Debug::FRAME_DROPPED_IN_IC_CALL; 1668 *mode = Debug::FRAME_DROPPED_IN_IC_CALL;
1669 frame_has_padding = Debug::FramePaddingLayout::kIsSupported; 1669 frame_has_padding = Debug::FramePaddingLayout::kIsSupported;
1670 } else if (pre_top_frame_code == 1670 } else if (pre_top_frame_code ==
1671 isolate->debug()->debug_break_slot()) { 1671 isolate->debug()->debug_break_slot()) {
1672 // OK, we can drop debug break slot. 1672 // OK, we can drop debug break slot.
1673 *mode = Debug::FRAME_DROPPED_IN_DEBUG_SLOT_CALL; 1673 *mode = Debug::FRAME_DROPPED_IN_DEBUG_SLOT_CALL;
1674 frame_has_padding = Debug::FramePaddingLayout::kIsSupported; 1674 frame_has_padding = Debug::FramePaddingLayout::kIsSupported;
1675 } else if (pre_top_frame_code == 1675 } else if (pre_top_frame_code ==
1676 isolate->builtins()->builtin( 1676 isolate->builtins()->builtin(
(...skipping 420 matching lines...) Expand 10 before | Expand all | Expand 10 after
2097 2097
2098 bool LiveEditFunctionTracker::IsActive(Isolate* isolate) { 2098 bool LiveEditFunctionTracker::IsActive(Isolate* isolate) {
2099 return false; 2099 return false;
2100 } 2100 }
2101 2101
2102 #endif // ENABLE_DEBUGGER_SUPPORT 2102 #endif // ENABLE_DEBUGGER_SUPPORT
2103 2103
2104 2104
2105 2105
2106 } } // namespace v8::internal 2106 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/ic.cc ('k') | src/objects.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698