Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Side by Side Diff: src/debug.cc

Issue 11821049: Combine DEBUG_BREAK and DEBUG_PREPARE_STEP_IN into one IC stub kind DEBUG_STUB, encoding DEBUG_BREA… (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comments Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/builtins.h ('k') | src/ic.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1569 matching lines...) Expand 10 before | Expand all | Expand 10 after
1580 1580
1581 // No step next action - don't continue. 1581 // No step next action - don't continue.
1582 return false; 1582 return false;
1583 } 1583 }
1584 1584
1585 1585
1586 // Check whether the code object at the specified address is a debug break code 1586 // Check whether the code object at the specified address is a debug break code
1587 // object. 1587 // object.
1588 bool Debug::IsDebugBreak(Address addr) { 1588 bool Debug::IsDebugBreak(Address addr) {
1589 Code* code = Code::GetCodeFromTargetAddress(addr); 1589 Code* code = Code::GetCodeFromTargetAddress(addr);
1590 return code->ic_state() == DEBUG_BREAK; 1590 return code->is_debug_break();
1591 } 1591 }
1592 1592
1593 1593
1594 // Check whether a code stub with the specified major key is a possible break 1594 // Check whether a code stub with the specified major key is a possible break
1595 // point location when looking for source break locations. 1595 // point location when looking for source break locations.
1596 bool Debug::IsSourceBreakStub(Code* code) { 1596 bool Debug::IsSourceBreakStub(Code* code) {
1597 CodeStub::Major major_key = CodeStub::GetMajorKey(code); 1597 CodeStub::Major major_key = CodeStub::GetMajorKey(code);
1598 return major_key == CodeStub::CallFunction; 1598 return major_key == CodeStub::CallFunction;
1599 } 1599 }
1600 1600
(...skipping 2175 matching lines...) Expand 10 before | Expand all | Expand 10 after
3776 { 3776 {
3777 Locker locker; 3777 Locker locker;
3778 Isolate::Current()->debugger()->CallMessageDispatchHandler(); 3778 Isolate::Current()->debugger()->CallMessageDispatchHandler();
3779 } 3779 }
3780 } 3780 }
3781 } 3781 }
3782 3782
3783 #endif // ENABLE_DEBUGGER_SUPPORT 3783 #endif // ENABLE_DEBUGGER_SUPPORT
3784 3784
3785 } } // namespace v8::internal 3785 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/builtins.h ('k') | src/ic.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698