Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 11778005: JavascriptAppModalDialog tests and necessary infrastructure. (Closed)

Created:
7 years, 11 months ago by aruslan
Modified:
7 years, 11 months ago
Reviewers:
Ted C, Jay Civelli
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, Philippe, aurimas (slooooooooow)
Visibility:
Public.

Description

JavascriptAppModalDialog tests and necessary infrastructure. BUG=155330 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175429

Patch Set 1 #

Total comments: 36

Patch Set 2 : Implemented the last test ("after closing a tab"). #

Total comments: 2

Patch Set 3 : Review suggestions addressed. #

Patch Set 4 : Upstreamed pliard@'s click-after-dismiss regression test. #

Total comments: 2

Messages

Total messages: 12 (0 generated)
aruslan
Please help with the review. I'll add other OWNERS once we are good to go.
7 years, 11 months ago (2013-01-04 21:21:52 UTC) #1
Ted C
https://codereview.chromium.org/11778005/diff/1/chrome/android/javatests/src/org/chromium/chrome/browser/test/ModalDialogTest.java File chrome/android/javatests/src/org/chromium/chrome/browser/test/ModalDialogTest.java (right): https://codereview.chromium.org/11778005/diff/1/chrome/android/javatests/src/org/chromium/chrome/browser/test/ModalDialogTest.java#newcode6 chrome/android/javatests/src/org/chromium/chrome/browser/test/ModalDialogTest.java:6: * Test suite for displaying and functioning of modal ...
7 years, 11 months ago (2013-01-05 00:13:13 UTC) #2
Ted C
https://codereview.chromium.org/11778005/diff/5001/chrome/android/javatests/src/org/chromium/chrome/browser/test/ModalDialogTest.java File chrome/android/javatests/src/org/chromium/chrome/browser/test/ModalDialogTest.java (right): https://codereview.chromium.org/11778005/diff/5001/chrome/android/javatests/src/org/chromium/chrome/browser/test/ModalDialogTest.java#newcode310 chrome/android/javatests/src/org/chromium/chrome/browser/test/ModalDialogTest.java:310: assertNull("The dialog should have been dismissed when its tab ...
7 years, 11 months ago (2013-01-05 00:14:51 UTC) #3
aruslan
https://codereview.chromium.org/11778005/diff/1/chrome/android/javatests/src/org/chromium/chrome/browser/test/ModalDialogTest.java File chrome/android/javatests/src/org/chromium/chrome/browser/test/ModalDialogTest.java (right): https://codereview.chromium.org/11778005/diff/1/chrome/android/javatests/src/org/chromium/chrome/browser/test/ModalDialogTest.java#newcode6 chrome/android/javatests/src/org/chromium/chrome/browser/test/ModalDialogTest.java:6: * Test suite for displaying and functioning of modal ...
7 years, 11 months ago (2013-01-05 02:46:31 UTC) #4
Ted C
lgtm
7 years, 11 months ago (2013-01-07 18:15:41 UTC) #5
aruslan
jcivelli@ -- please review and apply the OWNERS seal of approval for content/public/android and content/public/test/android.
7 years, 11 months ago (2013-01-07 18:50:12 UTC) #6
Jay Civelli
LGTM for content/public/android stuff https://codereview.chromium.org/11778005/diff/7005/content/public/android/java/src/org/chromium/content/browser/ContentView.java File content/public/android/java/src/org/chromium/content/browser/ContentView.java (right): https://codereview.chromium.org/11778005/diff/7005/content/public/android/java/src/org/chromium/content/browser/ContentView.java#newcode214 content/public/android/java/src/org/chromium/content/browser/ContentView.java:214: // @VisibleForTesting Why is this ...
7 years, 11 months ago (2013-01-07 19:19:59 UTC) #7
aruslan
Thanks, Jay! https://codereview.chromium.org/11778005/diff/7005/content/public/android/java/src/org/chromium/content/browser/ContentView.java File content/public/android/java/src/org/chromium/content/browser/ContentView.java (right): https://codereview.chromium.org/11778005/diff/7005/content/public/android/java/src/org/chromium/content/browser/ContentView.java#newcode214 content/public/android/java/src/org/chromium/content/browser/ContentView.java:214: // @VisibleForTesting Currently there is no dependency ...
7 years, 11 months ago (2013-01-07 19:48:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aruslan@chromium.org/11778005/7005
7 years, 11 months ago (2013-01-07 19:54:24 UTC) #9
commit-bot: I haz the power
Retried try job too often on win_aura for step(s) interactive_ui_tests
7 years, 11 months ago (2013-01-07 22:06:16 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aruslan@chromium.org/11778005/7005
7 years, 11 months ago (2013-01-07 22:33:52 UTC) #11
commit-bot: I haz the power
7 years, 11 months ago (2013-01-08 00:31:14 UTC) #12
Message was sent while issue was closed.
Change committed as 175429

Powered by Google App Engine
This is Rietveld 408576698