chrome/android/java/src/org/chromium/chrome/browser/TabBase.java - Issue 11778005: JavascriptAppModalDialog tests and necessary infrastructure.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/TabBase.java

Issue 11778005: JavascriptAppModalDialog tests and necessary infrastructure. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Upstreamed pliard@'s click-after-dismiss regression test. Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/android/java/src/org/chromium/chrome/browser/TabBase.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/TabBase.java b/chrome/android/java/src/org/chromium/chrome/browser/TabBase.java

index f65d228b19537479dfcfb5d6f2ba0132a6aad275..bf83f23cea6a5490a5b5155e0bdcc6fde855a0d9 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/TabBase.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/TabBase.java

@@ -70,6 +70,9 @@ public class TabBase {

* be used.

public void destroy() {

+ for (int i = 0; i < mObservers.size(); ++i) {

+ mObservers.get(i).onCloseTab(TabBase.this);

+ }

destroyContentView();

if (mNativeTabBaseAndroidImpl != 0) {

mCleanupReference.cleanupNow();