chrome/android/testshell/java/src/org/chromium/chrome/testshell/ChromiumTestShellActivity.java - Issue 11778005: JavascriptAppModalDialog tests and necessary infrastructure.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/testshell/java/src/org/chromium/chrome/testshell/ChromiumTestShellActivity.java

Issue 11778005: JavascriptAppModalDialog tests and necessary infrastructure. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Upstreamed pliard@'s click-after-dismiss regression test. Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/test/util/TabBaseUtils.java ('k') | chrome/android/testshell/java/src/org/chromium/chrome/testshell/TestShellToolbar.java » ('j') | content/public/android/java/src/org/chromium/content/browser/ContentView.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/testshell/java/src/org/chromium/chrome/testshell/ChromiumTestShellActivity.java

diff --git a/chrome/android/testshell/java/src/org/chromium/chrome/testshell/ChromiumTestShellActivity.java b/chrome/android/testshell/java/src/org/chromium/chrome/testshell/ChromiumTestShellActivity.java

index e754bb83b289591a4ba40b1072236764bdfd181d..b8cb09f94fdc7e697ffb6dfc833d72b3f7f5fdc8 100644

--- a/chrome/android/testshell/java/src/org/chromium/chrome/testshell/ChromiumTestShellActivity.java

+++ b/chrome/android/testshell/java/src/org/chromium/chrome/testshell/ChromiumTestShellActivity.java

@@ -130,6 +130,14 @@ public class ChromiumTestShellActivity extends ChromiumActivity {

return tab != null ? tab.getContentView() : null;

}

+ /**

+ * Creates a {@link TabBase} with a URL specified by {@code url}.

+ * @param url The URL the new {@link TabBase} should start with.

+ */

+ public void createTab(String url) {

+ mTabManager.createTab(url);

+ }

private void waitForDebuggerIfNeeded() {

if (CommandLine.getInstance().hasSwitch(CommandLine.WAIT_FOR_JAVA_DEBUGGER)) {

Log.e(TAG, "Waiting for Java debugger to connect...");