content/public/android/java/src/org/chromium/content/browser/ContentView.java - Issue 11778005: JavascriptAppModalDialog tests and necessary infrastructure.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContentView.java

Issue 11778005: JavascriptAppModalDialog tests and necessary infrastructure. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Upstreamed pliard@'s click-after-dismiss regression test. Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/testshell/javatests/src/org/chromium/chrome/testshell/ChromiumTestShellTestBase.java ('k') | content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestContentViewClientWrapper.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/ContentView.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentView.java b/content/public/android/java/src/org/chromium/content/browser/ContentView.java

index 27b937a39f6754ca0b3d25d89fe6565cd1cb1197..c984e47926f8a62b0021e8bc8fd7d84eb618e0c8 100644

--- a/content/public/android/java/src/org/chromium/content/browser/ContentView.java

+++ b/content/public/android/java/src/org/chromium/content/browser/ContentView.java

@@ -211,7 +211,8 @@ public class ContentView extends FrameLayout implements ContentViewCore.Internal

mContentViewCore.setContentViewClient(client);

}

- ContentViewClient getContentViewClient() {

+ // @VisibleForTesting

Jay Civelli 2013/01/07 19:19:59 Why is this commented?

aruslan 2013/01/07 19:48:01 Currently there is no dependency from org.chromium

+ public ContentViewClient getContentViewClient() {

return mContentViewCore.getContentViewClient();

}