Issue 11740026: Pull delegate check back into IsDownloadReadyForCompletion so that if

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11740026: Pull delegate check back into IsDownloadReadyForCompletion so that if (Closed)

Created:
7 years, 11 months ago by Randy Smith (Not in Mondays)

Modified:
7 years, 11 months ago

Reviewers:
asanka

CC:
chromium-reviews, benjhayden+dwatch_chromium.org, joi+watch-content_chromium.org, jam, rdsmith+dwatch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Pull delegate check back into IsDownloadReadyForCompletion so that if the delegate check results in a transition -> DANGEROUS, we notice that rather than complete the download. BUG=164777 R=asanka@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175032

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+28 lines, -34 lines)			Patch
M	content/browser/download/download_item_impl.h	View	3 chunks	+5 lines, -6 lines	0 comments	Download
M	content/browser/download/download_item_impl.cc	View	4 chunks	+10 lines, -17 lines	0 comments	Download
M	content/browser/download/download_item_impl_delegate.h	View	1 chunk	+4 lines, -5 lines	0 comments	Download
M	content/browser/download/download_item_impl_delegate.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	content/browser/download/download_manager_impl.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/download/download_manager_impl.cc	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	content/public/browser/download_manager_delegate.h	View	1 chunk	+3 lines, -1 line	0 comments	Download

Total messages: 4 (0 generated)

Randy Smith (Not in Mondays)

Ok. I think this is ready for initial review. I still need to push it ...

7 years, 11 months ago (2013-01-03 19:26:27 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdsmith@chromium.org/11740026/3001

7 years, 11 months ago (2013-01-03 20:09:48 UTC) #3

Message was sent while issue was closed.

Change committed as 175032