content/browser/download/download_manager_impl.h - Issue 11740026: Pull delegate check back into IsDownloadReadyForCompletion so that if

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/download/download_manager_impl.h

Issue 11740026: Pull delegate check back into IsDownloadReadyForCompletion so that if (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixed test. Created 7 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/download/download_manager_impl.h

diff --git a/content/browser/download/download_manager_impl.h b/content/browser/download/download_manager_impl.h

index 0e6d6ba1d0ca1b9d44c65e9bd86a934e02d6b2af..c545a0f7ae2ea79fc16d917d10402ce0f2cb90c8 100644

--- a/content/browser/download/download_manager_impl.h

+++ b/content/browser/download/download_manager_impl.h

@@ -120,7 +120,7 @@ class CONTENT_EXPORT DownloadManagerImpl : public DownloadManager,

// (Note that |GetBrowserContext| are present in both interfaces.)

virtual void DetermineDownloadTarget(

DownloadItemImpl* item, const DownloadTargetCallback& callback) OVERRIDE;

- virtual void ReadyForDownloadCompletion(

+ virtual bool ShouldCompleteDownload(

DownloadItemImpl* item, const base::Closure& complete_callback) OVERRIDE;

virtual bool ShouldOpenFileBasedOnExtension(const FilePath& path) OVERRIDE;

virtual bool ShouldOpenDownload(