content/browser/download/download_item_impl_delegate.cc - Issue 11740026: Pull delegate check back into IsDownloadReadyForCompletion so that if

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/download/download_item_impl_delegate.cc

Issue 11740026: Pull delegate check back into IsDownloadReadyForCompletion so that if (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixed test. Created 7 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/download/download_item_impl_delegate.cc

diff --git a/content/browser/download/download_item_impl_delegate.cc b/content/browser/download/download_item_impl_delegate.cc

index bbfbea1065502a31382f35f5a22230e48026fac8..b4201aa2dc3fef45c0545f885e8c86cc819be6c4 100644

--- a/content/browser/download/download_item_impl_delegate.cc

+++ b/content/browser/download/download_item_impl_delegate.cc

@@ -37,10 +37,10 @@ void DownloadItemImplDelegate::DetermineDownloadTarget(

target_path);

}

-void DownloadItemImplDelegate::ReadyForDownloadCompletion(

+bool DownloadItemImplDelegate::ShouldCompleteDownload(

DownloadItemImpl* download,

const base::Closure& complete_callback) {

- complete_callback.Run();

+ return true;

}

bool DownloadItemImplDelegate::ShouldOpenDownload(