Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Side by Side Diff: content/browser/download/download_manager_impl.h

Issue 11740026: Pull delegate check back into IsDownloadReadyForCompletion so that if (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed test. Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_DOWNLOAD_DOWNLOAD_MANAGER_IMPL_H_ 5 #ifndef CONTENT_BROWSER_DOWNLOAD_DOWNLOAD_MANAGER_IMPL_H_
6 #define CONTENT_BROWSER_DOWNLOAD_DOWNLOAD_MANAGER_IMPL_H_ 6 #define CONTENT_BROWSER_DOWNLOAD_DOWNLOAD_MANAGER_IMPL_H_
7 7
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 10
(...skipping 102 matching lines...) Expand 10 before | Expand all | Expand 10 after
113 // and then notifies this update to the file's observer. 113 // and then notifies this update to the file's observer.
114 void OnFileRemovalDetected(int32 download_id); 114 void OnFileRemovalDetected(int32 download_id);
115 115
116 // Remove from internal maps. 116 // Remove from internal maps.
117 int RemoveDownloadItems(const DownloadItemImplVector& pending_deletes); 117 int RemoveDownloadItems(const DownloadItemImplVector& pending_deletes);
118 118
119 // Overridden from DownloadItemImplDelegate 119 // Overridden from DownloadItemImplDelegate
120 // (Note that |GetBrowserContext| are present in both interfaces.) 120 // (Note that |GetBrowserContext| are present in both interfaces.)
121 virtual void DetermineDownloadTarget( 121 virtual void DetermineDownloadTarget(
122 DownloadItemImpl* item, const DownloadTargetCallback& callback) OVERRIDE; 122 DownloadItemImpl* item, const DownloadTargetCallback& callback) OVERRIDE;
123 virtual void ReadyForDownloadCompletion( 123 virtual bool ShouldCompleteDownload(
124 DownloadItemImpl* item, const base::Closure& complete_callback) OVERRIDE; 124 DownloadItemImpl* item, const base::Closure& complete_callback) OVERRIDE;
125 virtual bool ShouldOpenFileBasedOnExtension(const FilePath& path) OVERRIDE; 125 virtual bool ShouldOpenFileBasedOnExtension(const FilePath& path) OVERRIDE;
126 virtual bool ShouldOpenDownload( 126 virtual bool ShouldOpenDownload(
127 DownloadItemImpl* item, 127 DownloadItemImpl* item,
128 const ShouldOpenDownloadCallback& callback) OVERRIDE; 128 const ShouldOpenDownloadCallback& callback) OVERRIDE;
129 virtual void CheckForFileRemoval(DownloadItemImpl* download_item) OVERRIDE; 129 virtual void CheckForFileRemoval(DownloadItemImpl* download_item) OVERRIDE;
130 virtual void DownloadOpened(DownloadItemImpl* download) OVERRIDE; 130 virtual void DownloadOpened(DownloadItemImpl* download) OVERRIDE;
131 virtual void DownloadRemoved(DownloadItemImpl* download) OVERRIDE; 131 virtual void DownloadRemoved(DownloadItemImpl* download) OVERRIDE;
132 virtual void ShowDownloadInBrowser(DownloadItemImpl* download) OVERRIDE; 132 virtual void ShowDownloadInBrowser(DownloadItemImpl* download) OVERRIDE;
133 133
(...skipping 24 matching lines...) Expand all
158 DownloadManagerDelegate* delegate_; 158 DownloadManagerDelegate* delegate_;
159 159
160 net::NetLog* net_log_; 160 net::NetLog* net_log_;
161 161
162 DISALLOW_COPY_AND_ASSIGN(DownloadManagerImpl); 162 DISALLOW_COPY_AND_ASSIGN(DownloadManagerImpl);
163 }; 163 };
164 164
165 } // namespace content 165 } // namespace content
166 166
167 #endif // CONTENT_BROWSER_DOWNLOAD_DOWNLOAD_MANAGER_IMPL_H_ 167 #endif // CONTENT_BROWSER_DOWNLOAD_DOWNLOAD_MANAGER_IMPL_H_
OLDNEW
« no previous file with comments | « content/browser/download/download_item_impl_delegate.cc ('k') | content/browser/download/download_manager_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698