Chromium Code Reviews
Help | Chromium Project | Sign in
(639)

Issue 11362156: Use new ncval as rdfa validator wrapper in regression tests. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 5 months ago by Vlad Shcherbina
Modified:
1 year, 4 months ago
Reviewers:
bradn
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Use new ncval as rdfa validator wrapper in regression tests.


BUG= http://code.google.com/p/nativeclient/issues/detail?id=3107
TEST= validator bots


Committed: http://src.chromium.org/viewvc/native_client?view=rev&revision=10300

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Lint Patch
M buildbot/buildbot_standard.py View 2 chunks +5 lines, -4 lines 0 comments ? errors Download
Trybot results:
Commit:

Messages

Total messages: 9
Vlad Shcherbina
This change would only work on top of https://chromiumcodereview.appspot.com/11415009/ (because new ncval correctly accepts anomalous ...
1 year, 5 months ago #1
bradn
LGTM I assume you'll remove the old option in a later CL?
1 year, 5 months ago #2
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://nativeclient-status.appspot.com/cq/shcherbina@google.com/11362156/16007
1 year, 4 months ago #3
I haz the power (commit-bot)
Try job failure for 11362156-16007 (retry) on nacl-lucid_64-newlib-arm_qemu-pnacl for steps "annotate, scons [arm] [small_tests medium_tests] ...
1 year, 4 months ago #4
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://nativeclient-status.appspot.com/cq/shcherbina@google.com/11362156/16007
1 year, 4 months ago #5
I haz the power (commit-bot)
Try job failure for 11362156-16007 (retry) on nacl-lucid_64-newlib-arm_qemu-pnacl for steps "annotate, scons [arm] [small_tests medium_tests] ...
1 year, 4 months ago #6
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://nativeclient-status.appspot.com/cq/shcherbina@google.com/11362156/16007
1 year, 4 months ago #7
I haz the power (commit-bot)
Change committed as 10300
1 year, 4 months ago #8
Vlad Shcherbina
1 year, 4 months ago #9
On 2012/11/15 17:44:09, bradn wrote:
> LGTM
> 
> I assume you'll remove the old option in a later CL?

Sure, I'm removing it in https://chromiumcodereview.appspot.com/11418063/
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6