Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 11418063: Validator_ragel: get rid of validator_test.c (Closed)

Created:
8 years, 1 month ago by Vlad Shcherbina
Modified:
8 years, 1 month ago
Reviewers:
khim
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Validator_ragel: get rid of validator_test.c Validator_test.c was used in the following places: 1) tests from validator_x86/testdata 2) tests from validator_ragel/unreviewed/validator_test.py 3) regression tests from tests/abi_corpus 4) validator performance benchmark Now 1)-3) are switched to new ncval, and separate executable for benchmark is added, so validator_test can be safely removed. BUG= http://code.google.com/p/nativeclient/issues/detail?id=3107 TEST= bots Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=10308

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -327 lines) Patch
M src/trusted/validator_ragel/build.scons View 1 chunk +0 lines, -6 lines 0 comments Download
D src/trusted/validator_ragel/unreviewed/validator_test.c View 1 chunk +0 lines, -321 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Vlad Shcherbina
Please take a look.
8 years, 1 month ago (2012-11-19 15:19:53 UTC) #1
khim
LGTM (less code is always better if functionality is intact)
8 years, 1 month ago (2012-11-19 15:23:48 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
8 years, 1 month ago (2012-11-19 15:31:12 UTC) #3
Vlad Shcherbina
On 2012/11/19 15:31:12, I haz the power (commit-bot) wrote: > No LGTM from a valid ...
8 years, 1 month ago (2012-11-20 07:59:44 UTC) #4
commit-bot: I haz the power
8 years, 1 month ago (2012-11-20 08:00:12 UTC) #5
No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

Powered by Google App Engine
This is Rietveld 408576698