Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 11415009: Validator regression tests (abi_corpus): skip some anomalous nexes. (Closed)

Created:
8 years, 1 month ago by Vlad Shcherbina
Modified:
8 years, 1 month ago
Reviewers:
bradn
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Validator regression tests (abi_corpus): skip some anomalous nexes. BUG= http://code.google.com/p/nativeclient/issues/detail?id=3149 TEST= validator bot Committed: http://src.chromium.org/viewvc/native_client?view=rev&revision=10291

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -2 lines) Patch
M tests/abi_corpus/corpus_errors.py View 2 chunks +22 lines, -0 lines 0 comments Download
M tests/abi_corpus/corpus_utils.py View 2 chunks +8 lines, -2 lines 1 comment Download
M tests/abi_corpus/validator_regression_test.py View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Vlad Shcherbina
Please take a look.
8 years, 1 month ago (2012-11-15 16:28:44 UTC) #1
bradn
LGTM https://chromiumcodereview.appspot.com/11415009/diff/1/tests/abi_corpus/corpus_utils.py File tests/abi_corpus/corpus_utils.py (right): https://chromiumcodereview.appspot.com/11415009/diff/1/tests/abi_corpus/corpus_utils.py#newcode328 tests/abi_corpus/corpus_utils.py:328: eta_seconds = int(eta % 60) :-) cute, I ...
8 years, 1 month ago (2012-11-15 17:42:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://nativeclient-status.appspot.com/cq/shcherbina@google.com/11415009/1
8 years, 1 month ago (2012-11-15 20:51:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://nativeclient-status.appspot.com/cq/shcherbina@google.com/11415009/1
8 years, 1 month ago (2012-11-16 10:44:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://nativeclient-status.appspot.com/cq/shcherbina@google.com/11415009/1
8 years, 1 month ago (2012-11-16 15:21:06 UTC) #5
commit-bot: I haz the power
8 years, 1 month ago (2012-11-16 18:01:44 UTC) #6
Change committed as 10291

Powered by Google App Engine
This is Rietveld 408576698