Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11359201: Remove TabContents from TabStripModelObserver::TabReplacedAt. (Closed)

Created:
8 years, 1 month ago by Avi (use Gerrit)
Modified:
8 years, 1 month ago
Reviewers:
sky
CC:
chromium-reviews, sadrul, marja+watch_chromium.org, tfarina, ben+watch_chromium.org, Aaron Boodman, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Remove TabContents from TabStripModelObserver::TabReplacedAt. BUG=107201 TEST=no visible change Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=167955

Patch Set 1 #

Patch Set 2 : gtk fix #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -133 lines) Patch
M chrome/browser/extensions/api/web_navigation/web_navigation_api.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/web_navigation/web_navigation_api.cc View 1 chunk +7 lines, -13 lines 0 comments Download
M chrome/browser/extensions/browser_event_router.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/browser_event_router.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M chrome/browser/sessions/session_restore.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sessions/session_service.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sessions/session_service.cc View 1 2 7 chunks +18 lines, -23 lines 0 comments Download
M chrome/browser/ui/ash/launcher/browser_launcher_item_controller.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/launcher/browser_launcher_item_controller.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/browser.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser.cc View 1 2 2 chunks +9 lines, -11 lines 0 comments Download
M chrome/browser/ui/browser_command_controller.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser_command_controller.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/browser_commands.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser_tabrestore.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_strip_model_observer_bridge.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_strip_model_observer_bridge.mm View 2 chunks +9 lines, -20 lines 0 comments Download
M chrome/browser/ui/gtk/tabs/tab_strip_gtk.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/tabs/tab_strip_gtk.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/tabs/tab_strip_model.cc View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/ui/tabs/tab_strip_model_observer.h View 3 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/ui/tabs/tab_strip_model_observer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/tabs/tab_strip_model_unittest.cc View 1 2 1 chunk +4 lines, -5 lines 0 comments Download
M chrome/browser/ui/toolbar/wrench_menu_model.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/toolbar/wrench_menu_model.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/unload_controller.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/unload_controller.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/tabs/browser_tab_strip_controller.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Avi (use Gerrit)
8 years, 1 month ago (2012-11-14 22:20:14 UTC) #1
sky
LGTM
8 years, 1 month ago (2012-11-14 23:23:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/11359201/5001
8 years, 1 month ago (2012-11-14 23:24:59 UTC) #3
commit-bot: I haz the power
Retried try job too often for step(s) compile
8 years, 1 month ago (2012-11-15 05:10:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/11359201/12001
8 years, 1 month ago (2012-11-15 16:01:03 UTC) #5
commit-bot: I haz the power
8 years, 1 month ago (2012-11-15 18:04:17 UTC) #6 
Change committed as 167955

Powered by Google App Engine
This is Rietveld 408576698