chrome/browser/ui/browser_command_controller.cc - Issue 11359201: Remove TabContents from TabStripModelObserver::TabReplacedAt.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser_command_controller.cc

Issue 11359201: Remove TabContents from TabStripModelObserver::TabReplacedAt. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/browser_command_controller.cc

diff --git a/chrome/browser/ui/browser_command_controller.cc b/chrome/browser/ui/browser_command_controller.cc

index c26a7c756baea7ee6ac30c9b273f625904fc62f1..93df2cdf7da9b80951e4e48a80041ff9a41a86b1 100644

--- a/chrome/browser/ui/browser_command_controller.cc

+++ b/chrome/browser/ui/browser_command_controller.cc

@@ -723,11 +723,11 @@ void BrowserCommandController::TabDetachedAt(WebContents* contents, int index) {

}

void BrowserCommandController::TabReplacedAt(TabStripModel* tab_strip_model,

- TabContents* old_contents,

- TabContents* new_contents,

+ WebContents* old_contents,

+ WebContents* new_contents,

int index) {

- RemoveInterstitialObservers(old_contents->web_contents());

- AddInterstitialObservers(new_contents->web_contents());

+ RemoveInterstitialObservers(old_contents);

+ AddInterstitialObservers(new_contents);

}

////////////////////////////////////////////////////////////////////////////////