Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2483)

Unified Diff: chrome/browser/ui/cocoa/tabs/tab_strip_model_observer_bridge.mm

Issue 11359201: Remove TabContents from TabStripModelObserver::TabReplacedAt. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/tabs/tab_strip_model_observer_bridge.mm
diff --git a/chrome/browser/ui/cocoa/tabs/tab_strip_model_observer_bridge.mm b/chrome/browser/ui/cocoa/tabs/tab_strip_model_observer_bridge.mm
index 77810d40325fb55f584d1daa0ded52423a5d4c8e..3940b72f238a9bf2eb21f4e35157def4a8371e6e 100644
--- a/chrome/browser/ui/cocoa/tabs/tab_strip_model_observer_bridge.mm
+++ b/chrome/browser/ui/cocoa/tabs/tab_strip_model_observer_bridge.mm
@@ -9,15 +9,6 @@
using content::WebContents;
-namespace {
-
-// TODO(avi): Remove when TabStripModelObserver sends WebContents.
-content::WebContents* WebContentsOf(TabContents* tab_contents) {
- return tab_contents ? tab_contents->web_contents() : NULL;
-}
-
-} // namespace
-
TabStripModelObserverBridge::TabStripModelObserverBridge(TabStripModel* model,
id controller)
: controller_(controller), model_(model) {
@@ -96,24 +87,22 @@ void TabStripModelObserverBridge::TabChangedAt(WebContents* contents,
}
}
-void TabStripModelObserverBridge::TabReplacedAt(
- TabStripModel* tab_strip_model,
- TabContents* old_contents,
- TabContents* new_contents,
- int index) {
+void TabStripModelObserverBridge::TabReplacedAt(TabStripModel* tab_strip_model,
+ WebContents* old_contents,
+ WebContents* new_contents,
+ int index) {
if ([controller_ respondsToSelector:
@selector(tabReplacedWithContents:previousContents:atIndex:)]) {
- [controller_ tabReplacedWithContents:WebContentsOf(new_contents)
- previousContents:WebContentsOf(old_contents)
+ [controller_ tabReplacedWithContents:new_contents
+ previousContents:old_contents
atIndex:index];
} else {
- TabChangedAt(WebContentsOf(new_contents), index, ALL);
+ TabChangedAt(new_contents, index, ALL);
}
}
-void TabStripModelObserverBridge::TabMiniStateChanged(
- WebContents* contents,
- int index) {
+void TabStripModelObserverBridge::TabMiniStateChanged(WebContents* contents,
+ int index) {
if ([controller_ respondsToSelector:
@selector(tabMiniStateChangedWithContents:atIndex:)]) {
[controller_ tabMiniStateChangedWithContents:contents
« no previous file with comments | « chrome/browser/ui/cocoa/tabs/tab_strip_model_observer_bridge.h ('k') | chrome/browser/ui/gtk/tabs/tab_strip_gtk.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698