Issue 11299122: chrome/browser/ui: Do not use Value::Create* functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11299122: chrome/browser/ui: Do not use Value::Create* functions. (Closed)

Created:
8 years, 1 month ago by tfarina

Modified:
8 years ago

Reviewers:
sky, Evan Stade

CC:
chromium-reviews, Raghu Simha, haitaol1, akalin, tim (not reviewing), tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

chrome/browser/ui: Do not use Value::Create* functions. The first half is here, the other is webui, but that spans too much files to fit in this change. Webui will be done in a follow up CL. BUG=160586 R=sky@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=169064

Patch Set 1 #

Total comments: 1

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -13 lines)			Patch
M	chrome/browser/ui/chrome_select_file_policy_unittest.cc	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/search_engines/keyword_editor_controller_unittest.cc	View	1 chunk	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/sync/one_click_signin_helper.cc	View	2 chunks	+3 lines, -3 lines	1 comment	Download
M	chrome/browser/ui/sync/one_click_signin_helper_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/about_ipc_dialog.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/11299122/1

8 years, 1 month ago (2012-11-21 15:22:45 UTC) #3

Evan Stade

8 years ago (2012-11-26 23:03:13 UTC) #5

Message was sent while issue was closed.

https://chromiumcodereview.appspot.com/11299122/diff/1/chrome/browser/ui/sync...
File chrome/browser/ui/sync/one_click_signin_helper.cc (left):

https://chromiumcodereview.appspot.com/11299122/diff/1/chrome/browser/ui/sync...
chrome/browser/ui/sync/one_click_signin_helper.cc:408: const scoped_ptr<Value>
email_value(Value::CreateStringValue(email));
this should not be a scoped pointer.

Expand Messages | Collapse Messages