Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1570)

Side by Side Diff: chrome/browser/ui/views/about_ipc_dialog.cc

Issue 11299122: chrome/browser/ui: Do not use Value::Create* functions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Need to include this before any other file because it defines 5 // Need to include this before any other file because it defines
6 // IPC_MESSAGE_LOG_ENABLED. We need to use it to define 6 // IPC_MESSAGE_LOG_ENABLED. We need to use it to define
7 // IPC_MESSAGE_MACROS_LOG_ENABLED so that all_messages.h will generate the 7 // IPC_MESSAGE_MACROS_LOG_ENABLED so that all_messages.h will generate the
8 // ViewMsgLog et al. functions. 8 // ViewMsgLog et al. functions.
9 #include "ipc/ipc_message.h" 9 #include "ipc/ipc_message.h"
10 10
(...skipping 115 matching lines...) Expand 10 before | Expand all | Expand 10 after
126 if (!current_profile) 126 if (!current_profile)
127 return; 127 return;
128 PrefService* prefs = current_profile->GetPrefs(); 128 PrefService* prefs = current_profile->GetPrefs();
129 if (!prefs->FindPreference(prefs::kIpcDisabledMessages)) 129 if (!prefs->FindPreference(prefs::kIpcDisabledMessages))
130 return; 130 return;
131 ListValue* list = prefs->GetMutableList(prefs::kIpcDisabledMessages); 131 ListValue* list = prefs->GetMutableList(prefs::kIpcDisabledMessages);
132 list->Clear(); 132 list->Clear();
133 for (std::set<int>::const_iterator itr = disabled_messages_.begin(); 133 for (std::set<int>::const_iterator itr = disabled_messages_.begin();
134 itr != disabled_messages_.end(); 134 itr != disabled_messages_.end();
135 ++itr) { 135 ++itr) {
136 list->Append(Value::CreateIntegerValue(*itr)); 136 list->Append(new base::FundamentalValue(*itr));
137 } 137 }
138 */ 138 */
139 } 139 }
140 140
141 void OnButtonClick(int id) { 141 void OnButtonClick(int id) {
142 int count = messages->GetItemCount(); 142 int count = messages->GetItemCount();
143 for (int i = 0; i < count; ++i) 143 for (int i = 0; i < count; ++i)
144 messages->SetCheckState(i, id == IDC_MessagesAll); 144 messages->SetCheckState(i, id == IDC_MessagesAll);
145 } 145 }
146 146
(...skipping 214 matching lines...) Expand 10 before | Expand all | Expand 10 after
361 361
362 namespace chrome { 362 namespace chrome {
363 363
364 void ShowAboutIPCDialog() { 364 void ShowAboutIPCDialog() {
365 AboutIPCDialog::RunDialog(); 365 AboutIPCDialog::RunDialog();
366 } 366 }
367 367
368 } // namespace chrome 368 } // namespace chrome
369 369
370 #endif // IPC_MESSAGE_LOG_ENABLED 370 #endif // IPC_MESSAGE_LOG_ENABLED
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698