chrome/browser/ui: Do not use Value::Create* functions.

chrome/browser/ui/sync/one_click_signin_helper.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/sync/one_click_signin_helper.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/compiler_specific.h"
 #include "base/metrics/histogram.h"
@@ skipping 305 matching lines @@
   pref_service->SetBoolean(prefs::kReverseAutologinEnabled, false);
 }
 
 void OneClickInfoBarDelegateImpl::AddEmailToOneClickRejectedList(
     const std::string& email) {
   PrefService* pref_service =
       TabContents::FromWebContents(owner()->GetWebContents())->
           profile()->GetPrefs();
   ListPrefUpdate updater(pref_service,
                          prefs::kReverseAutologinRejectedEmailList);
-  updater->AppendIfNotPresent(base::Value::CreateStringValue(email));
+  updater->AppendIfNotPresent(new base::StringValue(email));
 }
 
 void OneClickInfoBarDelegateImpl::RecordHistogramAction(int action) {
   UMA_HISTOGRAM_ENUMERATION("AutoLogin.Reverse", action,
                             one_click_signin::HISTOGRAM_MAX);
 }
 
 OneClickSigninHelper::OneClickSigninHelper(content::WebContents* web_contents)
     : content::WebContentsObserver(web_contents),
       auto_accept_(NO_AUTO_ACCEPT) {
@@ skipping 61 matching lines @@
             return false;
         }
       }
     }
 
     // If email was already rejected by this profile for one-click sign-in.
     if (!email.empty()) {
       const ListValue* rejected_emails = profile->GetPrefs()->GetList(
           prefs::kReverseAutologinRejectedEmailList);
       if (!rejected_emails->empty()) {
-        const scoped_ptr<Value> email_value(Value::CreateStringValue(email));

[Evan Stade, 2012/11/26 23:03:13]

this should not be a scoped pointer.

-        ListValue::const_iterator iter = rejected_emails->Find(
+        const scoped_ptr<Value> email_value(new base::StringValue(email));
+        base::ListValue::const_iterator iter = rejected_emails->Find(
             *email_value);
         if (iter != rejected_emails->end())
           return false;
       }
     }
 
     // If we're about to show a one-click infobar but the user has started
     // a concurrent signin flow (perhaps via the promo), we may not have yet
     // established an authenticated username but we still shouldn't move
     // forward with two simultaneous signin processes.  This is a bit
@@ skipping 252 matching lines @@
   session_index_ = session_index;
   email_ = email;
 }
 
 void OneClickSigninHelper::SavePassword(const std::string& password) {
   // TODO(rogerta): in the case of a 2-factor or captcha or some other type of
   // challenge, its possible for the user to never complete the signin.
   // Should have a way to detect this and clear the password member.
   password_ = password;
 }