Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3306)

Unified Diff: chrome/browser/ui/sync/one_click_signin_helper.cc

Issue 11299122: chrome/browser/ui: Do not use Value::Create* functions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/sync/one_click_signin_helper.cc
diff --git a/chrome/browser/ui/sync/one_click_signin_helper.cc b/chrome/browser/ui/sync/one_click_signin_helper.cc
index 30a1a52af97e2d96ddcc4856acd1cd8bbe81020f..f96a2cff2e553b8a70e703360fffa44b3c4a52b5 100644
--- a/chrome/browser/ui/sync/one_click_signin_helper.cc
+++ b/chrome/browser/ui/sync/one_click_signin_helper.cc
@@ -323,7 +323,7 @@ void OneClickInfoBarDelegateImpl::AddEmailToOneClickRejectedList(
profile()->GetPrefs();
ListPrefUpdate updater(pref_service,
prefs::kReverseAutologinRejectedEmailList);
- updater->AppendIfNotPresent(base::Value::CreateStringValue(email));
+ updater->AppendIfNotPresent(new base::StringValue(email));
}
void OneClickInfoBarDelegateImpl::RecordHistogramAction(int action) {
@@ -405,8 +405,8 @@ bool OneClickSigninHelper::CanOffer(content::WebContents* web_contents,
const ListValue* rejected_emails = profile->GetPrefs()->GetList(
prefs::kReverseAutologinRejectedEmailList);
if (!rejected_emails->empty()) {
- const scoped_ptr<Value> email_value(Value::CreateStringValue(email));
Evan Stade 2012/11/26 23:03:13 this should not be a scoped pointer.
- ListValue::const_iterator iter = rejected_emails->Find(
+ const scoped_ptr<Value> email_value(new base::StringValue(email));
+ base::ListValue::const_iterator iter = rejected_emails->Find(
*email_value);
if (iter != rejected_emails->end())
return false;

Powered by Google App Engine
This is Rietveld 408576698