Chromium Code Reviews
Help | Chromium Project | Sign in
(59)

Issue 11267035: Fix layering violation where content is included by gpu. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 6 months ago by ccameron1
Modified:
1 year, 5 months ago
Reviewers:
piman
CC:
chromium-reviews_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Fix layering violation where content is included by gpu.

Make WebGraphicsContext3DCommandBufferImpl aways use CommandBufferProxyImpl
instead of the more abstract CommandBufferProxy. Then remove methods used
only by WebGraphicsContext3DCommandBufferImpl from CommandBufferProxy.

BUG=157175
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=164564

Patch Set 1 #

Patch Set 2 : Remove .gitmodules changes #

Patch Set 3 : Remove NOTIMPLEMENTED entrypoints #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -133 lines) Lint Patch
M content/common/gpu/client/command_buffer_proxy_impl.h View 1 2 4 chunks +34 lines, -14 lines 0 comments 2 errors Download
M content/common/gpu/client/gpu_channel_host.h View 3 chunks +5 lines, -6 lines 0 comments 0 errors Download
M content/common/gpu/client/gpu_channel_host.cc View 3 chunks +5 lines, -5 lines 0 comments ? errors Download
M content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.h View 5 chunks +4 lines, -4 lines 0 comments 0 errors Download
M content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc View 2 chunks +2 lines, -2 lines 0 comments 0 errors Download
M content/renderer/pepper/pepper_platform_context_3d_impl.h View 1 chunk +1 line, -1 line 0 comments ? errors Download
M content/renderer/pepper/pepper_platform_context_3d_impl.cc View 3 chunks +3 lines, -3 lines 0 comments ? errors Download
M gpu/ipc/command_buffer_proxy.h View 1 2 3 chunks +0 lines, -39 lines 0 comments ? errors Download
M ppapi/proxy/ppapi_command_buffer_proxy.h View 1 2 1 chunk +0 lines, -13 lines 0 comments ? errors Download
M ppapi/proxy/ppapi_command_buffer_proxy.cc View 1 2 2 chunks +0 lines, -46 lines 0 comments ? errors Download
Commit:

Messages

Total messages: 9
ccameron1
There are also a massive number of methods in PpapiCommandBufferProxy which are marked as NOTIMPLEMENTED ...
1 year, 6 months ago #1
ccameron1
I went ahead and got rid of all of the NOTIMPLEMENTED entrypoints from CommandBufferProxy. SetParent ...
1 year, 6 months ago #2
ccameron1
Ping. Ptal.
1 year, 5 months ago #3
apatrick_chromium
On 2012/10/26 17:38:47, ccameron1 wrote: > Ping. Ptal. Did you set your reviewers?
1 year, 5 months ago #4
ccameron1
Looks like the reviewers line got lost at some point.
1 year, 5 months ago #5
piman
lgtm
1 year, 5 months ago #6
ccameron1
Thanks!!
1 year, 5 months ago #7
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ccameron@chromium.org/11267035/10001
1 year, 5 months ago #8
I haz the power (commit-bot)
1 year, 5 months ago #9
Change committed as 164564
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6