content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc - Issue 11267035: Fix layering violation where content is included by gpu.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc

Issue 11267035: Fix layering violation where content is included by gpu. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Remove NOTIMPLEMENTED entrypoints Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.h ('k') | content/renderer/pepper/pepper_platform_context_3d_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc

diff --git a/content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc b/content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc

index 55d2d2a4f3c9aa49a01da9ae9019515424c4b3ca..e5b1de523723d71e5de0093f70c2c726b71c9d12 100644

--- a/content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc

+++ b/content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc

@@ -170,7 +170,7 @@ WebGraphicsContext3DCommandBufferImpl::

}

void WebGraphicsContext3DCommandBufferImpl::InitializeWithCommandBuffer(

- CommandBufferProxy* command_buffer,

+ CommandBufferProxyImpl* command_buffer,

const WebGraphicsContext3D::Attributes& attributes,

bool bind_generates_resources) {

DCHECK(command_buffer);

@@ -278,7 +278,7 @@ bool WebGraphicsContext3DCommandBufferImpl::InitializeCommandBuffer(

// for our share group isn't deleted.

// (There's also a lock in our destructor.)

base::AutoLock lock(g_all_shared_contexts_lock.Get());

- CommandBufferProxy* share_group = NULL;

+ CommandBufferProxyImpl* share_group = NULL;

if (attributes_.shareResources) {

WebGraphicsContext3DCommandBufferImpl* share_group_context =

g_all_shared_contexts.Pointer()->empty() ?