Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Unified Diff: gpu/ipc/command_buffer_proxy.h

Issue 11267035: Fix layering violation where content is included by gpu. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove NOTIMPLEMENTED entrypoints Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/ipc/command_buffer_proxy.h
diff --git a/gpu/ipc/command_buffer_proxy.h b/gpu/ipc/command_buffer_proxy.h
index 3ce13de5778e3cf6fcfd26c45f5291c8f7849b72..a992369e9aee9344fa3a2f1efa47a150e098870a 100644
--- a/gpu/ipc/command_buffer_proxy.h
+++ b/gpu/ipc/command_buffer_proxy.h
@@ -11,11 +11,6 @@
#include "gpu/command_buffer/common/command_buffer.h"
#include "gpu/command_buffer/common/command_buffer_shared.h"
-// TODO(fsamuel): this is a layering violation. http://crbug.com/157175
-namespace content {
-struct GpuMemoryAllocationForRenderer;
-}
-
// Client side proxy that forwards messages synchronously to a
// CommandBufferStub.
class GPU_EXPORT CommandBufferProxy : public gpu::CommandBuffer {
@@ -33,33 +28,6 @@ class GPU_EXPORT CommandBufferProxy : public gpu::CommandBuffer {
// the task whether the echo succeeds or not.
virtual bool Echo(const base::Closure& callback) = 0;
- // Sends an IPC message with the new state of surface visibility.
- virtual bool SetSurfaceVisible(bool visible) = 0;
-
- virtual bool DiscardBackbuffer() = 0;
- virtual bool EnsureBackbuffer() = 0;
-
- // Inserts a sync point, returning its ID. This is handled on the IO thread of
- // the GPU process, and so should be relatively fast, but its effect is
- // ordered wrt other messages (in particular, Flush). Sync point IDs are
- // global and can be used for cross-channel synchronization.
- virtual uint32 InsertSyncPoint() = 0;
-
- // Makes this command buffer wait on a sync point. This command buffer will be
- // unscheduled until the command buffer that inserted that sync point reaches
- // it, or gets destroyed.
- virtual void WaitSyncPoint(uint32) = 0;
-
- // Makes this command buffer invoke a task when a sync point is reached, or
- // the command buffer that inserted that sync point is destroyed.
- virtual bool SignalSyncPoint(uint32 sync_point,
- const base::Closure& callback) = 0;
-
- // Register a callback to invoke whenever we recieve a new memory allocation.
- virtual void SetMemoryAllocationChangedCallback(
- const base::Callback<void(
- const content::GpuMemoryAllocationForRenderer&)>& callback) = 0;
-
// Reparent a command buffer. TODO(apatrick): going forward, the notion of
// the parent / child relationship between command buffers is going away in
// favor of the notion of surfaces that can be drawn to in one command buffer
@@ -69,13 +37,6 @@ class GPU_EXPORT CommandBufferProxy : public gpu::CommandBuffer {
virtual void SetChannelErrorCallback(const base::Closure& callback) = 0;
- // Set a task that will be invoked the next time the window becomes invalid
- // and needs to be repainted. Takes ownership of task.
- virtual void SetNotifyRepaintTask(const base::Closure& callback) = 0;
-
- virtual void SetOnConsoleMessageCallback(
- const GpuConsoleMessageCallback& callback) = 0;
-
private:
DISALLOW_COPY_AND_ASSIGN(CommandBufferProxy);
};
« no previous file with comments | « content/renderer/pepper/pepper_platform_context_3d_impl.cc ('k') | ppapi/proxy/ppapi_command_buffer_proxy.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698