Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11145005: Migrate ui::Transform to gfx::Transform (Closed)

Created:
8 years, 2 months ago by shawnsingh
Modified:
8 years, 2 months ago
Reviewers:
sky
CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, sadrul, nkostylev+watch_chromium.org, ben+watch_chromium.org, Ian Vollick, tfarina, jonathan.backer, Aaron Boodman, oshima+watch_chromium.org, piman+watch_chromium.org, cc-bugs_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Migrate ui::Transform to gfx::Transform It is more appropriate for Transform class to belong with its fellow geometry classes in the gfx namespace. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161809

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : rebased again #

Patch Set 4 : Hopefully should work this time #

Unified diffs Side-by-side diffs Delta from patch set Stats (+301 lines, -298 lines) Patch
M ash/launcher/app_list_button.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/launcher/overflow_button.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ash/magnifier/magnification_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/rotator/screen_rotation.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray/system_tray_bubble.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ash/system/tray/tray_item_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/web_notification/web_notification_view.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ash/wm/gestures/long_press_affordance_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/image_grid.cc View 8 chunks +8 lines, -8 lines 0 comments Download
M ash/wm/session_state_animator.cc View 6 chunks +8 lines, -8 lines 0 comments Download
M ash/wm/window_animations.cc View 12 chunks +21 lines, -20 lines 0 comments Download
M ash/wm/window_animations_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M ash/wm/window_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace/workspace_animations.cc View 6 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/login/base_login_display_host.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/extensions/extension_install_dialog_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/root_window.h View 3 chunks +2 lines, -2 lines 0 comments Download
M ui/aura/root_window.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M ui/aura/window.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/aura/window.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/window_unittest.cc View 6 chunks +10 lines, -10 lines 0 comments Download
M ui/base/animation/tween.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/base/animation/tween.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M ui/base/events/event.h View 3 chunks +7 lines, -3 lines 0 comments Download
M ui/base/events/event.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M ui/compositor/layer.h View 6 chunks +9 lines, -8 lines 0 comments Download
M ui/compositor/layer.cc View 1 2 8 chunks +10 lines, -10 lines 0 comments Download
M ui/compositor/layer_animation_delegate.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/compositor/layer_animation_element.h View 3 chunks +2 lines, -3 lines 0 comments Download
M ui/compositor/layer_animation_element.cc View 1 2 3 4 chunks +6 lines, -5 lines 0 comments Download
M ui/compositor/layer_animation_element_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/compositor/layer_animation_sequence_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/compositor/layer_animator.h View 3 chunks +3 lines, -3 lines 0 comments Download
M ui/compositor/layer_animator.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/compositor/layer_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/compositor/test/test_layer_animation_delegate.h View 3 chunks +4 lines, -3 lines 0 comments Download
M ui/compositor/test/test_layer_animation_delegate.cc View 1 2 3 2 chunks +3 lines, -2 lines 0 comments Download
M ui/compositor/test/test_utils.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/compositor/test/test_utils.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/gfx/canvas.h View 2 chunks +2 lines, -5 lines 0 comments Download
M ui/gfx/canvas.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/interpolated_transform.h View 9 chunks +18 lines, -18 lines 0 comments Download
M ui/gfx/interpolated_transform.cc View 11 chunks +27 lines, -27 lines 0 comments Download
M ui/gfx/interpolated_transform_unittest.cc View 10 chunks +16 lines, -16 lines 0 comments Download
M ui/gfx/transform.h View 5 chunks +12 lines, -14 lines 0 comments Download
M ui/gfx/transform.cc View 8 chunks +16 lines, -16 lines 0 comments Download
M ui/gfx/transform_unittest.cc View 14 chunks +15 lines, -15 lines 0 comments Download
M ui/gfx/transform_util.h View 1 chunk +3 lines, -5 lines 0 comments Download
M ui/gfx/transform_util.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/gfx/transform_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/view.h View 4 chunks +4 lines, -4 lines 0 comments Download
M ui/views/view.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M ui/views/view_unittest.cc View 13 chunks +21 lines, -21 lines 0 comments Download
M ui/views/widget/widget.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
shawnsingh
8 years, 2 months ago (2012-10-12 22:13:17 UTC) #1
shawnsingh
please note this is the exact same patch as https://codereview.chromium.org/11087093/ I just had some infrastructure ...
8 years, 2 months ago (2012-10-12 22:15:03 UTC) #2
sky
LGTM
8 years, 2 months ago (2012-10-12 23:19:19 UTC) #3
shawnsingh
I'm fairly certain the last few bot failures are not a result of this patch, ...
8 years, 2 months ago (2012-10-14 16:48:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shawnsingh@chromium.org/11145005/8001
8 years, 2 months ago (2012-10-14 16:48:40 UTC) #5
commit-bot: I haz the power
8 years, 2 months ago (2012-10-14 18:15:37 UTC) #6 
Change committed as 161809

Powered by Google App Engine
This is Rietveld 408576698