Chromium Code Reviews
Help | Chromium Project | Sign in
(171)

Issue 10977051: Support for SDIV and MLS ARM instructions, and implement DoModI using them (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 6 months ago by subratokde
Modified:
1 year, 6 months ago
Reviewers:
danno
CC:
v8-dev_googlegroups.com
Visibility:
Public.

Description

Support for SDIV and MLS ARM instructions, and implement DoModI using them.
Also added support for the runtime detection to check if hardware supports SDIV/UDIV
Other new opportunities to exploit SDIV/UDIV will be done in separate issues.

Committed: https://code.google.com/p/v8/source/detail?r=12646

Patch Set 1 #

Total comments: 5

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+206 lines, -96 lines) Lint Patch
M src/arm/assembler-arm.h View 1 2 chunks +7 lines, -0 lines 0 comments 0 errors Download
M src/arm/assembler-arm.cc View 1 2 3 3 chunks +24 lines, -0 lines 0 comments 0 errors Download
M src/arm/disasm-arm.cc View 1 2 chunks +24 lines, -5 lines 0 comments 0 errors Download
M src/arm/lithium-codegen-arm.cc View 1 1 chunk +109 lines, -86 lines 0 comments 0 errors Download
M src/arm/simulator-arm.cc View 1 2 chunks +36 lines, -5 lines 0 comments 0 errors Download
M src/flag-definitions.h View 1 2 1 chunk +2 lines, -0 lines 0 comments 1 errors Download
M src/platform-linux.cc View 1 2 1 chunk +3 lines, -0 lines 0 comments 0 errors Download
M src/v8globals.h View 1 2 1 chunk +1 line, -0 lines 1 comment 0 errors Download
Trybot results:
Commit:

Messages

Total messages: 3
danno
In general, SDIV support seems like a reasonable thing to add, but it needs to ...
1 year, 6 months ago #1
danno
LGTM, I'll land this for you http://codereview.chromium.org/10977051/diff/17002/src/v8globals.h File src/v8globals.h (right): http://codereview.chromium.org/10977051/diff/17002/src/v8globals.h#newcode441 src/v8globals.h:441: SUDIV = 5, ...
1 year, 6 months ago #2
acleung
1 year, 6 months ago #3
On 2012/10/01 21:16:17, danno wrote:
> LGTM, I'll land this for you
> 
> http://codereview.chromium.org/10977051/diff/17002/src/v8globals.h
> File src/v8globals.h (right):
> 
> http://codereview.chromium.org/10977051/diff/17002/src/v8globals.h#newcode441
> src/v8globals.h:441: SUDIV = 5,   // ARM
> I changed this to 4 for the commit, I think keeping the sequence for a
platform
> is more consistent than uniqueness over all platforms, which is already not
> guaranteed.

Has someone tried this in Android Chrome? I ran the V8 benchmark and it hangs on
Crypto.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6